Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add irvifa to kubernetes-csi org #1124

Closed
wants to merge 2 commits into from
Closed

Add irvifa to kubernetes-csi org #1124

wants to merge 2 commits into from

Conversation

irvifa
Copy link
Member

@irvifa irvifa commented Aug 21, 2019

No description provided.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 21, 2019
@irvifa
Copy link
Member Author

irvifa commented Aug 21, 2019

/assign @nikhita

@k8s-ci-robot k8s-ci-robot added the sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience. label Aug 21, 2019
nikhita
nikhita approved these changes Aug 22, 2019
View reviewed changes
Copy link
Member

@nikhita nikhita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the record: @irvifa is already a member of @kubernetes and is implicitly eligible for membership to @kubernetes-csi.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 22, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: irvifa, nikhita

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 22, 2019
@nikhita
Copy link
Member

nikhita commented Aug 22, 2019

/hold

@irvifa can you update the commit message to Add irvifa to kubernetes-csi org?

@nikhita nikhita changed the title Add member for kubernetes-csi org. Add irvifa to kubernetes-csi org Aug 22, 2019
@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 22, 2019
@irvifa
Copy link
Member Author

irvifa commented Aug 22, 2019

I already updated the commit message as requested /cc @nikhita

@nikhita
Copy link
Member

nikhita commented Aug 22, 2019

@irvifa The commit message currently says Add member for kubernetes-csi org.. Maybe forgot to push?

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 22, 2019
@nikhita
Copy link
Member

nikhita commented Aug 22, 2019

/retest

@nikhita
Copy link
Member

nikhita commented Aug 22, 2019

/test pull-org-test-all
/lgtm
/hold cancel

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Aug 22, 2019
@irvifa
Copy link
Member Author

irvifa commented Aug 22, 2019

@nikhita seems like i have a conflict in this PR, do I need to do something?

@nikhita
Copy link
Member

nikhita commented Aug 22, 2019

Huh, that's weird ... from https://prow.k8s.io/tide-history

failed merging [1124]: [PR is unmergable. Do the Tide merge requirements match the GitHub settings for the repo? Pull Request is not mergeable]

@irvifa can you rebase, maybe it'll work then...

@irvifa
Copy link
Member Author

irvifa commented Aug 22, 2019

Huh.. @nikhita something must be off my handle already on https://github.com/kubernetes/org/blob/master/config/kubernetes-csi/org.yaml

@irvifa irvifa closed this Aug 22, 2019
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 22, 2019
@k8s-ci-robot
Copy link
Contributor

New changes are detected. LGTM label has been removed.

@nikhita
Copy link
Member

nikhita commented Aug 22, 2019

O_o Looks like some GitHub weirdness. Raising this in #testing-ops on slack.

@irvifa
Copy link
Member Author

irvifa commented Aug 22, 2019

Sure.. thanks..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikhita nikhita nikhita approved these changes

@justaugustus justaugustus Awaiting requested review from justaugustus

@ezzoueidi ezzoueidi Awaiting requested review from ezzoueidi

Assignees

@nikhita nikhita

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@irvifa @k8s-ci-robot @nikhita