Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add roycaihw to admin groups in kubernetes-client gen, python and go repos #1191

Merged
merged 1 commit into from
Sep 18, 2019
Merged

Add roycaihw to admin groups in kubernetes-client gen, python and go repos #1191

merged 1 commit into from
Sep 18, 2019

Conversation

roycaihw
Copy link
Member

Add @roycaihw to the admin groups in

  • kubernetes-client/python
  • kubernetes-client/python-base
  • kubernetes-client/go
  • kubernetes-client/go-base

since I already have admin access to these repos. I maintain the python client repo and do releases regularly.

Also add myself to the admin group in

  • kubernetes-client/gen

per conversation in kubernetes-client/gen#97 (comment).

@k8s-ci-robot
Copy link
Contributor

Welcome @roycaihw!

It looks like this is your first PR to kubernetes/org 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/org has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 16, 2019
@justaugustus
Copy link
Member

Makes sense, but I'll leave it to the current repo admins to approve.
/hold
/assign @brendandburns @mbohlool @yliaog

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 18, 2019
@yliaog
Copy link
Contributor

yliaog commented Sep 18, 2019

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 18, 2019
@cblecker
Copy link
Member

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cblecker, roycaihw, yliaog

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 18, 2019
@cblecker
Copy link
Member

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 18, 2019
@cblecker
Copy link
Member

I've removed your direct admin to these repos, since the groups will cover your access

@k8s-ci-robot k8s-ci-robot merged commit 1e902e0 into kubernetes:master Sep 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justaugustus justaugustus Awaiting requested review from justaugustus

@ezzoueidi ezzoueidi Awaiting requested review from ezzoueidi

Assignees

@mbohlool mbohlool

@brendandburns brendandburns

@yliaog yliaog

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@roycaihw @k8s-ci-robot @justaugustus @yliaog @cblecker @mbohlool @brendandburns