Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-enable Peribolos Team Sync #369

Merged
merged 1 commit into from Jan 17, 2019
Merged

Re-enable Peribolos Team Sync #369

merged 1 commit into from Jan 17, 2019

Conversation

cblecker
Copy link
Member

/assign @fejta
/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 15, 2019
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 15, 2019
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 15, 2019
@fejta
Copy link
Contributor

fejta commented Jan 15, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 15, 2019
idvoretskyi
idvoretskyi approved these changes Jan 16, 2019
View reviewed changes
Copy link
Member

@idvoretskyi idvoretskyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cblecker, idvoretskyi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [cblecker,idvoretskyi]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@fejta
Copy link
Contributor

fejta commented Jan 17, 2019

/hold cancel
Passed at least once with ghproxy enabled: https://gubernator.k8s.io/build/kubernetes-jenkins/logs/ci-org-peribolos/126?log#log

FYI @cblecker @cjwagner

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 17, 2019
@k8s-ci-robot k8s-ci-robot merged commit 9679d07 into kubernetes:master Jan 17, 2019
@cblecker cblecker deleted the enable-team-sync branch January 17, 2019 00:56
@fejta
Copy link
Contributor

fejta commented Jan 17, 2019

Woo!

https://gubernator.k8s.io/build/kubernetes-jenkins/logs/post-org-peribolos/102?log#log

https://testgrid.k8s.io/sig-testing-org#post-peribolos

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@idvoretskyi idvoretskyi idvoretskyi approved these changes

@calebamiles calebamiles Awaiting requested review from calebamiles

Assignees

@idvoretskyi idvoretskyi

@fejta fejta

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@cblecker @fejta @k8s-ci-robot @idvoretskyi