Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sig-docs-es members #685

Merged
merged 1 commit into from Apr 8, 2019

Conversation

@raelga
Copy link
Member

commented Apr 4, 2019

Owners and reviewers for the Spanish translation team joined at kubernetes/website#13543

/assign @zacharysarah

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Apr 4, 2019

Hi @raelga. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mrbobbytables

This comment has been minimized.

Copy link
Member

commented Apr 4, 2019

👋 @raelga Thanks for kickstarting the Spanish translations efforts! 👍

If you could, please fill out an org membership request and we can get both that and this PR processed. :)

@zacharysarah

This comment has been minimized.

Copy link
Contributor

commented Apr 4, 2019

/ok-to-test

config/kubernetes/sig-docs/teams.yaml Outdated Show resolved Hide resolved
config/kubernetes/sig-docs/teams.yaml Outdated Show resolved Hide resolved
@zacharysarah

This comment has been minimized.

Copy link
Contributor

commented Apr 4, 2019

@raelga 👋 Based on the CI results, it looks more additional folks need to open membership requests as well:

config_test.go:248: The following members of team sig-docs-es-reviews are not Kubernetes org members: electrocucaracha, glo-pena, raelga

@electrocucaracha

This comment has been minimized.

Copy link

commented Apr 5, 2019

@raelga 👋 Based on the CI results, it looks more additional folks need to open membership requests as well:

* @electrocucaracha

* @glo-pena

config_test.go:248: The following members of team sig-docs-es-reviews are not Kubernetes org members: electrocucaracha, glo-pena, raelga

@zacharysarah do you know how can I check which steps are missing to setup my account?

@zacharysarah

This comment has been minimized.

Copy link
Contributor

commented Apr 5, 2019

@electrocucaracha 👋

do you know how can I check which steps are missing to setup my account?

If you follow the link to a new membership request, the issue template contains the requirements. Please be sure to indicate that you're part of the new Spanish localization project.

@electrocucaracha electrocucaracha referenced this pull request Apr 5, 2019
6 of 6 tasks complete
@raelga

This comment has been minimized.

Copy link
Member Author

commented Apr 5, 2019

Thanks @mrbobbytables!

Membership requested at #688.

@remyleone

This comment has been minimized.

Copy link

commented Apr 5, 2019

/retest

@glo-pena glo-pena referenced this pull request Apr 5, 2019
6 of 6 tasks complete
@mrbobbytables mrbobbytables referenced this pull request Apr 5, 2019
6 of 6 tasks complete
@mrbobbytables

This comment has been minimized.

Copy link
Member

commented Apr 5, 2019

@raelga -- It's a small thing but would you mind squashing the PR down to 1 commit? We try and keep as clean a git history as we can in the org repo :x

I've also created PR #691 Which should take care of adding everyone to the kubernetes org. Once that gets merged that should unblock adding the sig-docs-es team :)

@mrbobbytables

This comment has been minimized.

Copy link
Member

commented Apr 5, 2019

/retest

@raelga raelga force-pushed the raelga:sig-docs-es-members branch from c17f48c to d5b6ef9 Apr 5, 2019

@raelga

This comment has been minimized.

Copy link
Member Author

commented Apr 5, 2019

/retest

@raelga

This comment has been minimized.

Copy link
Member Author

commented Apr 5, 2019

@mrbobbytables Everything green and squashed ✔️

@mrbobbytables

This comment has been minimized.

Copy link
Member

commented Apr 5, 2019

@raelga Thanks!

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label Apr 5, 2019

@rlenferink

This comment has been minimized.

Copy link
Member

commented Apr 8, 2019

Ping @zacharysarah for approval :)

/lgtm

@zacharysarah

This comment has been minimized.

Copy link
Contributor

commented Apr 8, 2019

/approve

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Apr 8, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: raelga, zacharysarah

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 6aedd3b into kubernetes:master Apr 8, 2019

4 checks passed

cla/linuxfoundation raelga authorized
Details
pull-org-test-all Job succeeded.
Details
pull-org-verify-all Job succeeded.
Details
tide In merge pool.
Details
@raelga raelga referenced this pull request Apr 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.