Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create project pool to be used by scalability build cluster #553

Closed
oxddr opened this issue Jun 4, 2019 · 8 comments
Closed

Create project pool to be used by scalability build cluster #553

oxddr opened this issue Jun 4, 2019 · 8 comments
Assignees
Labels
priority/awaiting-more-evidence Lowest priority. Possibly useful, but not yet enough support to actually get it done. sig/scalability Categorizes an issue or PR as relevant to SIG Scalability.

Comments

@oxddr
Copy link
Contributor

oxddr commented Jun 4, 2019

Yesterday we've created a separate build cluster to be use by Prow to run scalability tests [1]. It's missing Boskos and tests which rely on project pool doesn't work.

Plan for now:

  1. Disable dedidcated build cluster in kubemark-100 (it uses project pool)
  2. Create new project pool
  3. Setup Boskos in dedicated build cluster so projects can be picked by tests

[1] kubernetes/test-infra#12847 (comment)

@oxddr
Copy link
Contributor Author

oxddr commented Jun 4, 2019

/assign oxddr

@oxddr
Copy link
Contributor Author

oxddr commented Jun 4, 2019

Alternatively to maintaining a dedicated project pool (AFAIU it requires running Boskos in scalability build cluster, right @krzyzacy) we can only migrate tests with dedicated project. Especially those are ones, which cause most of troubles (they are long running and need lots of resources). This way we can minimize maintenance work on our side, but keep benefits of having a dedicated build cluster. A downside is that we run tests in two place. However this should be transparent most of the time AFAIU.

Opinions? @wojtek-t @mm4tt @mborsz @krzyzacy

@krzyzacy
Copy link
Member

krzyzacy commented Jun 4, 2019

The maintenance cost of boskos is relatively low, it runs both internal and external and we rarely need to worry about that, except when we don't have enough projects in the pool. But that's your call :-)

@mm4tt
Copy link
Contributor

mm4tt commented Jun 5, 2019

+1 for migrating only the tests with the dedicated projects for now.
I don't see much gain in doing that for smaller tests (using boskos), as they are not affected by the kubernetes/test-infra#11594 (or at least run often enough to mitigate the problem).
There are tasks with higher priority than this that we should work on right now.

Let's keep this bug open though. We can come back here when we have less on our plates.

@krzyzacy
Copy link
Member

krzyzacy commented Jun 5, 2019

sgtm - feel free to send follow up PRs, you just need to add cluster: scalability in the prowjobs that you want to run on your build cluster.

@oxddr
Copy link
Contributor Author

oxddr commented Jun 7, 2019

/priority awaiting-more-evidence
/sig scalability

@k8s-ci-robot k8s-ci-robot added sig/scalability Categorizes an issue or PR as relevant to SIG Scalability. priority/awaiting-more-evidence Lowest priority. Possibly useful, but not yet enough support to actually get it done. labels Jun 7, 2019
mirandachrist pushed a commit to mirandachrist/test-infra that referenced this issue Jun 17, 2019
Wait for project pool to be added
(kubernetes/perf-tests#553) and move it back
together with other tests (kubernetes#12867)
@oxddr
Copy link
Contributor Author

oxddr commented Jul 29, 2019

/close

We decided not to migrate tests other than 5k performance and correctness to a dedicated build cluster. The effort (e.g. setting up Boskos) is not worth gain (not sure if there is any).

@k8s-ci-robot
Copy link
Contributor

@oxddr: Closing this issue.

In response to this:

/close

We decided not to migrate tests other than 5k performance and correctness to a dedicated build cluster. The effort (e.g. setting up Boskos) is not worth gain (not sure if there is any).

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority/awaiting-more-evidence Lowest priority. Possibly useful, but not yet enough support to actually get it done. sig/scalability Categorizes an issue or PR as relevant to SIG Scalability.
Projects
None yet
Development

No branches or pull requests

4 participants