Fix typo in Github Bearer Token and remove redundant check for ignoring non-yaml files in config.go

[mirahmed753]

I was running into an auth issue despite setting my Github token properly. Upon investigation, I found that the request header for auth should look like: Authorization: Bearer <token>. In the current code, we have a colon after Bearer leading to my auth issues. Once removed, I was authenticated properly.

Unfortunately, this breaks retrieving the prow config because a bearer token adds some extra auth chars after the downloadURL. (e.g: https://raw.githubusercontent.com/kubernetes/test-infra/master/config/jobs/kubernetes/sig-scalability/sig-scalability-release-blocking-jobs.yaml?token=AXXXXXXXXXXXXXXXXXXXXZ). In the code:

• To ensure that we are only working with strings that end in .yaml, we check if the githubDirContent.Name has the suffix .yaml prior to adding it to our list of config paths in GetConfigsFromGithub()
• We do this same HasSuffix check again in getProwConfig() with githubDirContent.DownloadURL which fails because the downloadURL adds the auth chars as mentioned above

In this PR:

• I fix the bearer token typo
• I remove the redundant check in getProwConfig() since we already guarantee we're working with only yaml files in the first check in GetConfigsFromGithub()

[k8s-ci-robot]

Hi @mirahmed753. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[mirahmed753]

/assign @wojtek-t

[wojtek-t]

Why you're removing this one?

[wojtek-t]

This doesn't fit into this PR (and this is actually a useful check).

[mirahmed753]

I believe adding a bearer token breaks the HasSuffix() check here since the downloadURL will look like https://raw.githubusercontent.com/kubernetes/test-infra/master/config/jobs/kubernetes/sig-scalability/sig-scalability-release-blocking-jobs.yaml?token=AXXXXXXXXXXXXXXXXXXXXZ

Isn't this a redundant check since we guarantee yaml files in GetConfigsFromGithub()?

[mirahmed753]

This doesn't fit into this PR

I can rebase and just push the typo fix if it doesn't fit :D Going to wait for your reply to my prev comment before I do :)

[wojtek-t]

OK - the explanation makes sense to me and looking into the code it seems to be indeed reduntant.

[wojtek-t]

/ok-to-test
/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mirahmed753, wojtek-t

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• perfdash/OWNERS [wojtek-t]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment