Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unblock perfdash upgrade #1837

Merged
merged 1 commit into from Jun 15, 2021
Merged

Unblock perfdash upgrade #1837

merged 1 commit into from Jun 15, 2021

Conversation

VivekThrivikraman-est
Copy link

What type of PR is this?
/kind feature

What this PR does / why we need it:
This PR is for unblocking the perfdash upgrade.

Which issue(s) this PR fixes:
Fixes #1792

Special notes for your reviewer:

Does this PR introduce a user-facing change?:
NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 15, 2021
@k8s-ci-robot
Copy link
Contributor

Hi @VivekThrivikraman-est. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jun 15, 2021
@VivekThrivikraman-est
Copy link
Author

@mm4tt

mm4tt
mm4tt reviewed Jun 15, 2021
View reviewed changes
Copy link
Contributor

@mm4tt mm4tt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just two minor comments

perfdash/deployment.yaml Outdated
@@ -17,7 +17,7 @@ spec:
- name: perfdash
# Version 2.33 consumes > 32GiB of memory.
# TODO: Introduce 2.34 version which conditionally disables functionality added in 2.32 and disable it in this perf-dash instance.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's remove this TODO

perfdash/metrics-downloader.go Outdated
Options *DownloaderOptions
MetricsBkt MetricsBucket
Options *DownloaderOptions
allowParsersAllTests *bool
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's rename to allowParsersForAllTests and make it bool not *bool

mm4tt
mm4tt reviewed Jun 15, 2021
View reviewed changes
perfdash/deployment.yaml Outdated
@@ -16,7 +16,6 @@ spec:
containers:
- name: perfdash
# Version 2.33 consumes > 32GiB of memory.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one as well :)

mm4tt
mm4tt reviewed Jun 15, 2021
View reviewed changes
Copy link
Contributor

@mm4tt mm4tt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please address the remaining comment and squash all commits together and it'll be good to merge

perfdash/metrics-downloader.go Outdated
}

// NewDownloader creates a new Downloader.
func NewDownloader(opt *DownloaderOptions, bkt MetricsBucket) *Downloader {
func NewDownloader(opt *DownloaderOptions, bkt MetricsBucket, allowAllParsers *bool) *Downloader {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be also bool, it doesn't make sense to allow *bool here, what should we do if caller provides nil?

@mm4tt
Copy link
Contributor

mm4tt commented Jun 15, 2021

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 15, 2021
@mm4tt
Copy link
Contributor

mm4tt commented Jun 15, 2021

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 15, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mm4tt, VivekThrivikraman-est

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 15, 2021
@mm4tt
Copy link
Contributor

mm4tt commented Jun 15, 2021

Adding @jprzychodzen, the current scalability oncall.

Kuba, could you push the new perf-dash version once this PR merges?

@jprzychodzen
Copy link
Contributor

Sure, I will push new perf-dash.

Thanks for this change!

@k8s-ci-robot k8s-ci-robot merged commit b0c3afb into kubernetes:master Jun 15, 2021
@VivekThrivikraman-est VivekThrivikraman-est deleted the unblock-perfdash-2.33 branch June 15, 2021 11:43
@jprzychodzen
Copy link
Contributor

FYI - new perf-dash is up and running.

@VivekThrivikraman-est VivekThrivikraman-est mentioned this pull request Dec 7, 2021
Closed
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mm4tt mm4tt mm4tt left review comments

@mborsz mborsz Awaiting requested review from mborsz

@wojtek-t wojtek-t Awaiting requested review from wojtek-t

Assignees

@mm4tt mm4tt

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Upgrade of perfdash to 2.33 is blocked
4 participants
@VivekThrivikraman-est @k8s-ci-robot @mm4tt @jprzychodzen