Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pod startup: pre-define generic ephemeral volume type #1879

Merged

Conversation

pohly
Copy link
Contributor

@pohly pohly commented Sep 1, 2021

What type of PR is this?

/kind feature

What this PR does / why we need it:

This can be used to create pods with a varying number of generic ephemeral
inline volumes.

Example for usage with the "distributed" deployment of csi-driver-host-path:

  $ cat test.yaml
  PODS_PER_NODE: 5
  VOLUMES_PER_POD: 3
  VOL_SIZE: 1Gi
  STORAGE_CLASS: csi-hostpath-fast

  $ go run cmd/clusterloader.go -v=3 --kubeconfig=$KUBECONFIG --provider=local --nodes=1 \
       --testconfig=testing/experimental/storage/pod-startup/config.yaml \
       --testoverrides=testing/experimental/storage/pod-startup/volume-types/genericephemeralinline/override.yaml \
       --testoverrides=test.yaml

Which issue(s) this PR fixes:

Related-to: kubernetes/enhancements#1698

Does this PR introduce a user-facing change?:

the experimental pod startup test now also has a pre-defined volume type for generic ephemeral volumes

This can be used to create pods with a varying number of generic ephemeral
inline volumes.

Example for usage with the "distributed" deployment of csi-driver-host-path:

  $ cat test.yaml
  PODS_PER_NODE: 5
  VOLUMES_PER_POD: 3
  VOL_SIZE: 1Gi
  STORAGE_CLASS: csi-hostpath-fast

  $ go run cmd/clusterloader.go -v=3 --kubeconfig=$KUBECONFIG --provider=local --nodes=1 \
       --testconfig=testing/experimental/storage/pod-startup/config.yaml \
       --testoverrides=testing/experimental/storage/pod-startup/volume-types/genericephemeralinline/override.yaml \
       --testoverrides=test.yaml
@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 1, 2021
@wojtek-t
Copy link
Member

wojtek-t commented Sep 8, 2021

/lgtm
/approve

Thanks!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 8, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pohly, wojtek-t

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 8, 2021
@k8s-ci-robot k8s-ci-robot merged commit 60c7b83 into kubernetes:master Sep 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants