Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix YAML injections in the network policy enforcement test #2494

Merged
merged 1 commit into from
Jan 12, 2024

Conversation

dlapcevic
Copy link
Contributor

@dlapcevic dlapcevic commented Jan 8, 2024

Remove label key templating from the YAML files to pass the YAML injection checks introduced in #2421

Example error message from test failure:

reading template (deployment.yaml) error: replacing placeholders error: YAML Injection Detected

Similar for the Network Policy Enforcement measurement:

NetworkPolicyEnforcement - NetworkPolicyEnforcement error: error while creating test client deployment: TemplateToObject error: replacing placeholders error: YAML Injection Detected

/kind bug

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jan 8, 2024
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jan 8, 2024
@dlapcevic
Copy link
Contributor Author

/assign @marseel

/cc @alan-kut

@k8s-ci-robot
Copy link
Contributor

@dlapcevic: GitHub didn't allow me to request PR reviews from the following users: alan-kut.

Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/assign @marseel

/cc @alan-kut

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dlapcevic
Copy link
Contributor Author

/retest

@k8s-ci-robot
Copy link
Contributor

@dlapcevic: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-perf-tests-clusterloader2 7782916 link true /test pull-perf-tests-clusterloader2
pull-perf-tests-clusterloader2-kubemark 7782916 link true /test pull-perf-tests-clusterloader2-kubemark

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@dlapcevic
Copy link
Contributor Author

Hi @marseel, could we merge this since the failures are due to N2 machine quotas, and not related to the change.
Another PR has just been merged despite these failures #2483

I tested the change. Our tests that were previously broken are now passing with this.

@marseel
Copy link
Member

marseel commented Jan 12, 2024

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 12, 2024
@marseel marseel merged commit 9150ab7 into kubernetes:master Jan 12, 2024
4 of 7 checks passed
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dlapcevic, marseel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants