Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle release tags as versions correctly #191

Closed
ixdy opened this issue Nov 3, 2016 · 4 comments · Fixed by #192
Closed

handle release tags as versions correctly #191

ixdy opened this issue Nov 3, 2016 · 4 comments · Fixed by #192
Assignees
Labels
area/release-eng Issues or PRs related to the Release Engineering subproject sig/release Categorizes an issue or PR as relevant to SIG Release.

Comments

@ixdy
Copy link
Member

ixdy commented Nov 3, 2016

It seems like when a new release is tagged, the release scripts can't parse the version correctly.
https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/logs/kubernetes-build-1.3/138

Unable to get latest version from build tree!

kubectl version output:
Client Version: version.Info{Major:"1",
Minor:"3+", GitVersion:"v1.3.11-beta.0",
GitCommit:"759dd0dfb826658c78db42d97b77b9594cd43333", GitTreeState:"clean",
BuildDate:"2016-11-03T19:27:58Z", GoVersion:"go1.6.2", Compiler:"gc",
Platform:"linux/amd64"}

The issue seems to be that there's no .#commits+sha at the end of the version string, since there are no additional commits on the tag, but https://github.com/kubernetes/release/blob/master/lib/gitlib.sh#L42 expects the .#commits+sha suffix.

@david-mcmahon david-mcmahon self-assigned this Nov 3, 2016
@david-mcmahon
Copy link
Contributor

Yes, push-build.sh introduced a new use for that regex. I'll have a look.

@ixdy
Copy link
Member Author

ixdy commented Nov 3, 2016

This isn't the first time we've run into issues like this... kubernetes/kubernetes#24535 and kubernetes/kubernetes#24825 also reference it.

I'm still not sure what's doing the wrong thing. :)

@ixdy
Copy link
Member Author

ixdy commented Nov 3, 2016

Both the 1.3 and 1.4 builds are broken on Jenkins because of this.

@david-mcmahon
Copy link
Contributor

Those earlier issues were related, but I think the issue here is that we shifted the push activity to the release repo but the release repo never had to validate versions sans +sha. So this was just an oversight/bug at the time we moved to push-build.sh, so the regex needs to be made CI friendly.

@justaugustus justaugustus added sig/release Categorizes an issue or PR as relevant to SIG Release. area/release-eng Issues or PRs related to the Release Engineering subproject labels Dec 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/release-eng Issues or PRs related to the Release Engineering subproject sig/release Categorizes an issue or PR as relevant to SIG Release.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants