-
Notifications
You must be signed in to change notification settings - Fork 496
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
release note generation mangles markdown links #299
Comments
xref: #360 |
cc @kubernetes/sig-release-bugs |
I will try to understand the scripts. @david-mcmahon any ideas? |
For 1.9, I'm hoping to switch to the new Go implementation (#434). @jennybuckley @roycaihw Does the new implementation still exhibit this problem? |
Good point @enisoc. Once this gets submitted and we integrate with |
@enisoc @david-mcmahon Yes, I think it still exhibit the problem. HTML-izing markdown file is kind of complicated, and the Go implementation relies on the same sed command as #360 pointed out. |
Comparing the final version of the release notes with the draft [2] it was noted that markdown links will be rendered incorrectly due to what looks like an automated link to PR. The link generation is also subtly incorrect as some links of the form
github.com/someCompany/someRepo/issues/someIssue
will be rewritten asgithub.com/kubernetes/kubernetes/pull/someIssue
.cc: @bgrant0607
The text was updated successfully, but these errors were encountered: