Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

package kubelet and cni plugins in RPMs #37

Closed
mikedanese opened this issue Jul 19, 2016 · 8 comments
Closed

package kubelet and cni plugins in RPMs #37

mikedanese opened this issue Jul 19, 2016 · 8 comments
Labels
area/release-eng Issues or PRs related to the Release Engineering subproject sig/release Categorizes an issue or PR as relevant to SIG Release.

Comments

@mikedanese
Copy link
Member

mikedanese commented Jul 19, 2016

We should have seperate RPMs for cni plugins and kubelet. They should depend on a compatible docker version. They should be built and published during the release process.

cc @dgoodwin

@ingvagabund
Copy link
Contributor

@mikedanese @dgoodwin can you be more descriptive what is intent of this PR?

@dgoodwin
Copy link
Contributor

I'm just starting to look into this, but I think I should check that everyone is in agreement it's worth doing and make sure I understand the goals.

Kubernetes RPMs are available out of the box today with Fedora / RHEL / CentOS and have had a lot of effort put into them. They originate from a relatively large specfile that builds from source and applies relevant patches for the distros, sub-packages for master/node/client tools and it looks like one that can be used as a golang dependency. They also require the "docker" rpm we ship in our distribution, as opposed to "docker-engine" from Docker.

So benefits to doing another dramatically simplified spec file here (built by just fetching the upstream binary), we could likely get these packages out a little quicker than the Fedora packagers can react after a new release, it would work with the upstream docker-engine rpm, and theoretically work on other not RedHat rpm based distributions. Any other benefits I'd be missing?

Drawbacks however, there will probably not be as many eyes on these packages and the experience may not be as good as the one we can offer with kubernetes in the distributions themselves.

Are their benefits I'm missing, and if not do we feel this is sufficient to be worth pursuing?

@ingvagabund
Copy link
Contributor

So benefits to doing another dramatically simplified spec file here (built by just fetching the upstream binary), we could likely get these packages out a little quicker than the Fedora packagers can react after a new release,

So the task here is to provide a general rpm for various distributions that will fetch the kubelet (and possibly other binaries) from kubernetes/kubernetes releases?

it would work with the upstream docker-engine rpm, and theoretically work on other not RedHat rpm based distributions.

Kubernetes supports rkt as well. It would make more sense to have a requirement on a virtual provide (e.g. container-tech) that would by provided by installed docker, docker-engine, rkt or any other container technology implementation. Of course, one component conflicting with each other.

Any other benefits I'd be missing?

Drawbacks however, there will probably not be as many eyes on these packages and the experience may not be as good as the one we can offer with kubernetes in the distributions themselves.

Agree. Each distribution has in general different names of components, different dependencies, different installation paths, etc.

Are their benefits I'm missing, and if not do we feel this is sufficient to be worth pursuing?

@detiber
Copy link
Member

detiber commented Jul 20, 2016

I see there being two options that we have here.

  1. Publishing a repo specific for this use case, for which I would probably recommend distributing through COPR.
  2. Working with the upstream SIGs for Fedora/CentOS to align release schedules through their channels.

Granted 2 wouldn't support other RPM-based distros...

@mikedanese
Copy link
Member Author

mikedanese commented Jul 29, 2016

cc @mansoorj @kelseyhightower @kubernetes/sig-cluster-lifecycle

@errordeveloper
Copy link
Member

cc kubernetes/kubernetes#26093

@dgoodwin
Copy link
Contributor

dgoodwin commented Aug 8, 2016

Just getting back from vacation but an update of where things were before, in meeting we discussed and decided that yes, there is a desire for upstream k8s to publish an RPM as part of the build process. I've got a spec file working, we discussed how it would be built and integrated into the release process on slack as it requires RPM tooling to do so, and decided a Docker container to build would likely be best. I'm just rounding out that process now and hopefully will have something up this week.

@luxas
Copy link
Member

luxas commented Sep 30, 2016

This is now fixed. Yay!

@luxas luxas closed this as completed Sep 30, 2016
@justaugustus justaugustus added sig/release Categorizes an issue or PR as relevant to SIG Release. area/release-eng Issues or PRs related to the Release Engineering subproject labels Dec 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/release-eng Issues or PRs related to the Release Engineering subproject sig/release Categorizes an issue or PR as relevant to SIG Release.
Projects
None yet
Development

No branches or pull requests

7 participants