Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

charter: Add changes and election vacancies sections #249

Merged
merged 2 commits into from Jul 7, 2022
Merged

charter: Add changes and election vacancies sections #249

merged 2 commits into from Jul 7, 2022

Conversation

justaugustus
Copy link
Member

These commits were peeled off of #248, initially committed by @parispittman:

  • charter: Add section on process for charter changes
  • charter: Add section on elections and vacancies

Co-authored-by: Stephen Augustus foo@auggie.dev

There are no content changes, outside of fixing up links and referencing existing process/procedure.
cc: @kubernetes/steering-committee

@justaugustus
charter: Add section on process for charter changes
797adab 
Signed-off-by: Stephen Augustus <foo@auggie.dev>
@justaugustus justaugustus added this to In progress in committee-steering via automation Jul 6, 2022
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 6, 2022
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 6, 2022
@justaugustus
Copy link
Member Author

This is roughly a no-op, so the changes process should not apply here.
/assign @parispittman @dims @mrbobbytables

@dims
Copy link
Member

dims commented Jul 6, 2022

/hold for other reviewers and approvers

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Jul 6, 2022
@dims dims mentioned this pull request Jul 6, 2022
Merged
lavalamp
lavalamp reviewed Jul 6, 2022
View reviewed changes
charter.md Show resolved Hide resolved
@lavalamp
Copy link
Member

lavalamp commented Jul 6, 2022

I personally agree this is a no-op. However I think you should count this as part of the other change for the purpose of following the change policy, which does not make an exception for no-op changes.

@parispittman
Copy link
Contributor

lgtm

@justaugustus justaugustus mentioned this pull request Jul 7, 2022
Closed
6 tasks
@cblecker
Copy link
Member

cblecker commented Jul 7, 2022

I also read this as a noop and explicitly states and links current policy and practices.

LGTM

mrbobbytables
mrbobbytables reviewed Jul 7, 2022
View reviewed changes
Copy link
Member

@mrbobbytables mrbobbytables left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also believe this is a no-op. I understand the hesitation with current policy not explicitly calling out no-ops but I think this is reasonable. IMO a good follow-up would be to amend the change policy to account for this in the future.

lgtm

liggitt
liggitt reviewed Jul 7, 2022
View reviewed changes
charter.md Show resolved Hide resolved
@parispittman @justaugustus
charter: Add section on elections and vacancies
2bfc358 
Co-authored-by: Stephen Augustus <foo@auggie.dev>
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 7, 2022
@justaugustus
Copy link
Member Author

@kubernetes/steering-committee -- Reviews have been addressed and we all seem to be in agreement about this being a no-op.

Just needs another LGTM.
/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 7, 2022
@dims
Copy link
Member

dims commented Jul 7, 2022

/lgtm

@cblecker
Copy link
Member

cblecker commented Jul 7, 2022

/hold
We haven't set a vote on this yet. Holding per our change process.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 7, 2022
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 7, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, justaugustus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dims
Copy link
Member

dims commented Jul 7, 2022

LGTM

@tpepper
Copy link
Member

tpepper commented Jul 7, 2022

lgtm

@liggitt
Copy link
Member

liggitt commented Jul 7, 2022

lgtm here and in the meeting

@justaugustus
Copy link
Member Author

/hold cancel

@justaugustus
Copy link
Member Author

(Voted in today's meeting and 7/7 in favor of merging this)
Let's try that hold cancel again...
/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 7, 2022
@k8s-ci-robot k8s-ci-robot merged commit b5e4a9e into kubernetes:main Jul 7, 2022
committee-steering automation moved this from In progress to Done Jul 7, 2022
@justaugustus justaugustus deleted the elections-cleanup branch July 7, 2022 17:57
krmayankk
krmayankk reviewed Jul 13, 2022
View reviewed changes
elections.md
@@ -127,19 +127,7 @@ History of election officers:

### Vacancies

In the event of a resignation or other loss of a [bootstrap committee member],
the position will not be refilled.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what was the rationale earlier for why it will not be filled ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The bootstrap committee was 12 (13?) seats (extra big to be extra sure about initial set of decisions) and the goal was to get it down to 7 via attrition.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lol

was to get it down to 7 via attrition.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lavalamp lavalamp lavalamp left review comments

@liggitt liggitt liggitt left review comments

@cblecker cblecker cblecker left review comments

@parispittman parispittman parispittman left review comments

@mrbobbytables mrbobbytables mrbobbytables left review comments

@krmayankk krmayankk krmayankk left review comments

@tpepper tpepper Awaiting requested review from tpepper

Assignees

@dims dims

@parispittman parispittman

@mrbobbytables mrbobbytables

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
committee-steering
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
10 participants
@justaugustus @dims @lavalamp @parispittman @cblecker @k8s-ci-robot @tpepper @liggitt @mrbobbytables @krmayankk