Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace gubernator links with spyglass links #10375

Closed
10 tasks done
Katharine opened this issue Dec 6, 2018 · 9 comments
Closed
10 tasks done

Replace gubernator links with spyglass links #10375

Katharine opened this issue Dec 6, 2018 · 9 comments
Assignees
Labels
area/gubernator Issues or PRs related to code in /gubernator area/prow/deck Issues or PRs related to prow's deck component
Milestone

Comments

@Katharine
Copy link
Member

Katharine commented Dec 6, 2018

We want to deprecate gubernator (except for its PR dashboard). Before we can do that, we need to:

  • Merge the PR history view (add pr history dashboard to Deck #10169)
  • Show pod logs as necessary even when given GCS URLs
  • Add testgrid integration (but do we really want to couple prow and testgrid? gubernator does this by reading the testgrid config proto...)
  • Add links to view artifacts
  • Improve the failed test display (at least make the failure text more legible)
  • [ ] Node log viewing?
  • For transitional purposes, add a link to gubernator

Anything I missed? We can already:

  • Show the build log
  • Show test results
  • Show build metadata
  • Show job histories

Some of these things are probably uncommon (node logs?) and at least initially are sufficiently served by the link to gubernator.

@Katharine
Copy link
Member Author

/area prow/deck
/area gubernator
/assign

@k8s-ci-robot k8s-ci-robot added area/prow/deck Issues or PRs related to prow's deck component area/gubernator Issues or PRs related to code in /gubernator labels Dec 7, 2018
@spiffxp
Copy link
Member

spiffxp commented Dec 7, 2018

Add testgrid integration (but do we really want to couple prow and testgrid? gubernator does this by reading the testgrid config proto...)

The current coupling may be ugly, there's probably a better way to do it that will require some rearchitecting, but the mapping from job <-> history of job runs (in testgrid form) is very useful. I can quickly jump from how is this run doing, to how have all runs been doing

Improve the failed test display (at least make the failure text more legible)

Agree. I'm not sure how many people use the "click to see stdout/stderr" link, but if nothing else it's additional info captured in the junit file that could be displayed nicely

eg: https://gubernator.k8s.io/build/kubernetes-jenkins/logs/ci-kubernetes-node-kubelet/17584#k8sio-summary-api-nodeconformance-when-querying-statssummary-should-report-resource-usage-through-the-stats-api

@spiffxp
Copy link
Member

spiffxp commented Dec 7, 2018

From my design nerd perspective, it doesn't appear dense enough. Don't get me wrong, whitespace is good. This doesn't feel like it's been put through a pass with that kind of eye though.

Text is small. I see N different kinds of font styles. It would be nice use a grid or something for consistent alignment
screen shot 2018-12-07 at 11 08 00 am

@BenTheElder
Copy link
Member

BenTheElder commented Dec 7, 2018 via email

@Katharine
Copy link
Member Author

I'm pretty sure none of this has been put through any sort of pass beyond "yes, this is technically capable of rendering information from artifacts". There has been slightly more effort on the build logs.

@ibzib
Copy link
Contributor

ibzib commented Dec 11, 2018

re metadata viewer, I put in #10406. I wouldn't say it looks good now, but at least it's not spread out into different tables and cluttered with empty fields anymore.

@Katharine
Copy link
Member Author

I did some work on the UI to prettify it in #10929 / #10932, which hopefully at least mostly resolves the broadest design complaints (@spiffxp):

image

@spiffxp
Copy link
Member

spiffxp commented Feb 25, 2019

Will also want to update links in go.k8s.io/triage (test-infra/triage)

@Katharine
Copy link
Member Author

This happened.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/gubernator Issues or PRs related to code in /gubernator area/prow/deck Issues or PRs related to prow's deck component
Projects
None yet
Development

No branches or pull requests

5 participants