Add a plugin for /pony #10422
Add a plugin for /pony #10422
Conversation
k8s-ci-robot
added
cncf-cla: yes
k8s-ci-robot
added
the
approved
|
Grr, hit the wrong keys and submitted a half-typed PR. /cc @fejta |
| } | ||
|
|
||
| const ( | ||
| ponyURL = realHerd("https://theponyapi.com/pony.json") |
There was a problem hiding this comment.
Is this the API with which we will need to be careful? Does it expose user-provided content? Do we run the risk of posting inappropriate images here?
There was a problem hiding this comment.
All the images returned by this API (which is not the same one discussed previously, though that is its root data source) have been manually reviewed for appropriateness. It should be at least as safe as /meow
There was a problem hiding this comment.
@ixdy didn't we just have an oopsie with the cat plugin?
There was a problem hiding this comment.
@stevekuznetsov yes, there was apparently a bug in which images which were rejected were still available via a direct request. it's supposedly fixed now; all cat images are supposed to be reviewed first as well.
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 966c18de16dc267109de4be0c6bcd7143b560891
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Katharine, liztio The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
YES! |
|
We need to deploy a new version of prow before we can enable this |
|
Yeah except it fails tests somehow! |
|
I enthusiastically approve this PR :D |
This critical PR adds a /pony command, and thereby closes #10415.
It is based very heavily on the code and tests for the
dogandcatplugins (which, in turn, appear to be very heavily based on each other).Usage is either of the following:
/ponyfor a completely random pony, or/pony Pony Name, for a pony by that name.There is also some non-name tag support, such as
gifto get only animated ponies. They can be combined with commas:/pony giffor a random animated pony./pony gif, Pony Namefor an animated pony by that name.Random ponies are collected from https://theponyapi.com.