Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The cert-manager version we are using is not supported by letsencrypt. #14944

Closed
cjwagner opened this issue Oct 23, 2019 · 13 comments
Closed

The cert-manager version we are using is not supported by letsencrypt. #14944

cjwagner opened this issue Oct 23, 2019 · 13 comments
Assignees
Labels
kind/bug Categorizes issue or PR as related to a bug. kind/oncall-hotlist Categorizes issue or PR as tracked by test-infra oncall.

Comments

@cjwagner
Copy link
Member

We've been working with Jetstack, the authors of cert-manager, on a
series of fixes to the client. Cert-manager sometimes falls into a
traffic pattern where it sends really excessive traffic to Let's
Encrypt's servers, continuously. To mitigate this, we plan to start
blocking all traffic from cert-manager versions less than 0.8.0 (the
current semver minor release), as of November 1, 2019. Please upgrade
all of your cert-manager instances before then.

We're sending this email because this is the contact address of your
cert-manager instance at:

35.185.195.73 .

Version 0.8.0 is much better but we still observe excessive traffic in
some cases. We're working with Jetstack to improve these cases. As new
versions of cert-manager are released, we will add the non-current
versions to our block list after 3 months. We strongly encourage
cert-manager users to stay up-to-date with new versions.

You can subscribe to new version notifications by going to cert-manager's
GitHub project (https://github.com/jetstack/cert-manager), clicking
"Watch" in the upper right, then clicking "Releases only."

Also, there is an opportunity to help both Jetstack and Let's Encrypt.
Once you've upgraded, please check the logs for your cert-manager
instances from time to time. Are they making excessive requests to Let's
Encrypt (more than, say, 10 per day over multiple days)? If so, please
share details at cert-manager/cert-manager#1948 .

Thanks,
Let's Encrypt Team

We are currently using version v0.5.2:

image: "quay.io/jetstack/cert-manager-controller:v0.5.2"

Unfortunately there are backwards incompatible changes that make upgrading cert-manager more complicated than just changing the image version: https://docs.cert-manager.io/en/latest/tasks/upgrading/

The current certificate for prow.k8s.io is good until Monday, January 6, 2020 at 11:47:17 AM

/kind oncall-hotlist
@Katharine @fejta @BenTheElder @stevekuznetsov

I know we have discussed using Google managed SSL certificates for prow.k8s.io. If we want to make that change now would be a good time.

@cjwagner cjwagner added the kind/bug Categorizes issue or PR as related to a bug. label Oct 23, 2019
@k8s-ci-robot k8s-ci-robot added the kind/oncall-hotlist Categorizes issue or PR as tracked by test-infra oncall. label Oct 23, 2019
@Katharine
Copy link
Member

I am very inclined to switch to GKE-managed certs.

@Katharine
Copy link
Member

see #14945 for what that would ultimately look like.

@BenTheElder
Copy link
Member

what's the current status on this?

@Katharine
Copy link
Member

Katharine commented Nov 7, 2019

We need someone (@fejta, probably) to change over the kubernetes and kubernetes-sigs webhooks to point at https://prow-canary.k8s.io instead of https://prow.k8s.io, and then we can perform the switchover during some low-traffic time.

We have until January 6th to actually execute this plan, but sooner is better than later.

@fejta
Copy link
Contributor

fejta commented Nov 7, 2019

@fejta
Copy link
Contributor

fejta commented Nov 7, 2019

Done

@Katharine
Copy link
Member

@fejta
Copy link
Contributor

fejta commented Nov 7, 2019

Yes, and we're getting 200s

Request URL: https://prow-canary.k8s.io/hook
Request method: POST
content-type: application/json
Expect: 
User-Agent: GitHub-Hookshot/f1003bc
X-GitHub-Delivery: bffba280-01b1-11ea-95ad-0e33a0477690
X-GitHub-Event: issue_comment
X-Hub-Signature: sha1=bda9df71ef463adf5afc1829fa3c08b1ec25ff64

@Katharine
Copy link
Member

/pony

@k8s-ci-robot
Copy link
Contributor

@Katharine: pony image

In response to this:

/pony

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@fejta
Copy link
Contributor

fejta commented Dec 5, 2019

/assign @fejta @Katharine @clarketm

Want to try and flip this over this week?

@fejta
Copy link
Contributor

fejta commented Dec 10, 2019

Bueller?

@Katharine
Copy link
Member

Fixed by #15726, #15727 and #15728.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug. kind/oncall-hotlist Categorizes issue or PR as tracked by test-infra oncall.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants