Bad /assign causes "Error handling GenericCommentEvent" instead of user feedback

[petr-muller]

We saw someones /assign <someone> please take a look command to log an error instead of replying to the user that "please, take, a, look" could not be assigned. It used to do this in the past.

Log:

{
  component: "hook"   
  error: "status code 404 not one of [201], body: {"message":"Not Found","documentation_url":"https://developer.github.com/v3/issues/assignees/#add-assignees-to-an-issue"}"   
  event-type: "issue_comment"   
  level": "error"   
  msg: "Error handling GenericCommentEvent."   
  plugin: "assign"   
 }

See: openshift/console#3765 (comment)

xref: https://github.com/openshift/release/issues/6581

[stevekuznetsov]

cc @cjwagner this used to report an error when trying to assign "take a look" -- now it errors silently and assigns nobody, regression?

[adshmh]

After running a few tests, it seems GitHub API will ignore requests for assignment if the user cannot be assigned the issue. The plugin uses the API's response which lists the assigned users to figure out the list of ignored users and adds a comment accordingly.

However, if any of the specified users do not exist (or, interestingly, are an organisation account), GitHub API will return 404, which the plugin does not handle for assignment (for reviews it handles 422 code by making separate requests per login)

The please take a look fails because please is currently an organisation account (perhaps this is what changed, triggering a 404 response from GitHub API).

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

[fejta-bot]

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

[fejta-bot]

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

[k8s-ci-robot]

@fejta-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.