-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
boskos: changing type of a static resource in config doesn't update storage #16047
Comments
This doesn't entirely work. If you just apply a config with the resources deleted, Boskos won't delete any that are in-use. To remove them, you'd need to explicitly delete them using kubectl. |
There are quite a lot of config renames/edits that do not get appropriately reflected in cluster state. Notably reducing the size of a dynamic resource used to not remove the CRDs? I think we might need to revisit how that code works. |
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
Stale issues rot after 30d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
Moving to kubernetes-sigs/boskos#18. |
@ixdy: Closing this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What happened:
We renamed the type of some of our static resources to work around a bug in the janitor.
(That bug: we had a group of projects that didn't end in
-project
, and thus the janitor was passing the wrong flag:test-infra/boskos/janitor/janitor.go
Lines 92 to 99 in 761c11f
)
After applying the config, the old type still remained in storage (in the Kubernetes objects).
What you expected to happen:
Boskos would update storage (in the Kubernetes objects) reflecting the new type.
How to reproduce it (as minimally and precisely as possible):
I wrote a simple unit test that reproduces this failure: ixdy@d6714a6
It looks like when updating static resources, we just check to see whether the resources specified in the config exist in storage and vice-versa, only looking at the resource names. We do not consider that other metadata (such as type) may have changed.
Our planned workaround is to delete the resources from the config, then re-add them.
/area boskos
The text was updated successfully, but these errors were encountered: