boskos: changing type of a static resource in config doesn't update storage

[ixdy]

What happened:
We renamed the type of some of our static resources to work around a bug in the janitor.
(That bug: we had a group of projects that didn't end in -project, and thus the janitor was passing the wrong flag:

test-infra/boskos/janitor/janitor.go

Lines 92 to 99 in 761c11f

	func format(rtype string) string {
	splits := strings.Split(rtype, "-")
	return splits[len(splits)-1]
	}
	// Clean by janitor script
	func janitorClean(resource *common.Resource, flags []string) error {
	args := append([]string{fmt.Sprintf("--%s=%s", format(resource.Type), resource.Name)}, flags...)

)

After applying the config, the old type still remained in storage (in the Kubernetes objects).

What you expected to happen:
Boskos would update storage (in the Kubernetes objects) reflecting the new type.

How to reproduce it (as minimally and precisely as possible):
I wrote a simple unit test that reproduces this failure: ixdy@d6714a6

It looks like when updating static resources, we just check to see whether the resources specified in the config exist in storage and vice-versa, only looking at the resource names. We do not consider that other metadata (such as type) may have changed.

Our planned workaround is to delete the resources from the config, then re-add them.

/area boskos

[ixdy]

Our planned workaround is to delete the resources from the config, then re-add them.

This doesn't entirely work. If you just apply a config with the resources deleted, Boskos won't delete any that are in-use. To remove them, you'd need to explicitly delete them using kubectl.

[stevekuznetsov]

There are quite a lot of config renames/edits that do not get appropriately reflected in cluster state. Notably reducing the size of a dynamic resource used to not remove the CRDs? I think we might need to revisit how that code works.

[ixdy]

I think the issues with dynamic resources are described in #15906 (and hopefully fixed by #16021), but none of that touches static resources.

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

[fejta-bot]

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

[ixdy]

Moving to kubernetes-sigs/boskos#18.
/close

[k8s-ci-robot]

@ixdy: Closing this issue.

In response to this:

Moving to kubernetes-sigs/boskos#18.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.