Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move pr-test.k8s.io over to gubernator #195

Closed
fejta opened this issue Jun 20, 2016 · 10 comments
Closed

Move pr-test.k8s.io over to gubernator #195

fejta opened this issue Jun 20, 2016 · 10 comments
Assignees
@rmmh
Labels
area/gubernator Issues or PRs related to code in /gubernator

Comments

@fejta
Copy link
Contributor

fejta commented Jun 20, 2016

rather than a direct gcs link
@fejta fejta mentioned this issue Jun 20, 2016
Closed
@ixdy
Copy link
Member

ixdy commented Jun 20, 2016

ci-test.k8s.io too, please, though its requirements are a little bit more complicated:

I'd also say we should probably try to keep as much logic as possible out of the redirector, since it's not version controlled at all.

@ixdy
Copy link
Member

ixdy commented Jun 20, 2016

FWIW pr-test.k8s.io has similar requirements, except that the PR # is prefixed to the URI.

@ixdy
Copy link
Member

ixdy commented Jun 20, 2016

x-ref kubernetes/kubernetes#20161 which has discussion of the redirectors as they are currently set up

@ixdy ixdy added the area/gubernator Issues or PRs related to code in /gubernator label Jun 23, 2016
@ixdy ixdy mentioned this issue Jun 24, 2016
Merged
@thockin
Copy link
Member

thockin commented Jun 30, 2016

pr-test is done

@thockin
Copy link
Member

thockin commented Jun 30, 2016

@ixdy Can you spec precisely what redirects you want?

@fejta fejta mentioned this issue Jun 30, 2016
Closed
@thockin thockin closed this as completed Jul 15, 2016
@ixdy
Copy link
Member

ixdy commented Aug 3, 2016

Can we please fix ci-test.k8s.io too?

@thockin
Copy link
Member

thockin commented Aug 4, 2016

Sorry, I was waiting fro a precise mapping of URL patterns.

On Wed, Aug 3, 2016 at 12:39 PM, Jeff Grafton notifications@github.com
wrote:

Can we please fix ci-test.k8s.io too?

—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
#195 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AFVgVKta9ZyDH5KyTLeeIqkIWpuJBMsaks5qcO6KgaJpZM4I6MtA
.

@ixdy
Copy link
Member

ixdy commented Aug 4, 2016

@rmmh can you do this?

@fejta fejta reopened this Aug 4, 2016
@thockin
Copy link
Member

thockin commented Aug 5, 2016

I just need the mappings

On Wed, Aug 3, 2016 at 11:35 PM, Erick Fejta notifications@github.com
wrote:

Reopened #195 #195.

—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
#195 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AFVgVB0lCvTgKOR-5rduqsZ0Fvch8ve-ks5qcYhKgaJpZM4I6MtA
.

@rmmh
Copy link
Contributor

rmmh commented Aug 25, 2016

pr-test.k8s.io was fixed earlier, this was fixed in kubernetes/k8s.io#7

@rmmh rmmh closed this as completed Aug 25, 2016
mborsz pushed a commit to mborsz/test-infra that referenced this issue Dec 14, 2018
@k8s-ci-robot
Merge pull request kubernetes#195 from krzysied/perfdash_config_location
a9f5cc5 
Perfdash - config location
grantr pushed a commit to grantr/test-infra that referenced this issue Feb 21, 2020
@adrcunha @knative-prow-robot
Import dep-collector into test-infra (kubernetes#195)
0b3d4cd 
* Import dep-collector into test-infra

Bonus: `dummy.go` can now be removed.

* Adopt Knative license in dep-collector
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rmmh rmmh

Labels
area/gubernator Issues or PRs related to code in /gubernator
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@rmmh @fejta @thockin @ixdy