Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run a prowjob with podutils locally #6590

Closed
BenTheElder opened this issue Feb 1, 2018 · 23 comments
Closed

Run a prowjob with podutils locally #6590

BenTheElder opened this issue Feb 1, 2018 · 23 comments
Assignees
Labels
area/prow Issues or PRs related to prow kind/feature Categorizes issue or PR as related to a new feature. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. priority/backlog Higher priority than priority/awaiting-more-evidence.

Comments

@BenTheElder
Copy link
Member

Once we break out git checkout etc from the job container to being integrated with prow we can map kubernetes prow jobs to a wrapper around docker that translates the pod spec and mounts through the local git checkout and skips the log upload.

From a discussion with @dashpole and @krzyzacy

@BenTheElder
Copy link
Member Author

BenTheElder commented Feb 1, 2018

cc @cjwagner @stevekuznetsov

@BenTheElder BenTheElder added area/prow Issues or PRs related to prow kind/feature Categorizes issue or PR as related to a new feature. labels Feb 1, 2018
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 2, 2018
@BenTheElder
Copy link
Member Author

/remove-lifecycle stale
this is becoming more feasible soon.

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 2, 2018
@BenTheElder BenTheElder reopened this May 17, 2018
@BenTheElder
Copy link
Member Author

/assign
/priority backlog

@k8s-ci-robot k8s-ci-robot added the priority/backlog Higher priority than priority/awaiting-more-evidence. label May 17, 2018
@stevekuznetsov
Copy link
Contributor

/assign

@stevekuznetsov
Copy link
Contributor

Talked with Ben on Slack, we want a command line tool that will take as input:

  • Prow config (infra file + job dir)
  • job name
  • local directories holding code under test

This tool should spit out a docker run command for the user to use (or do we want to use the Docker client library to just spawn the container and tail logs?)

/cc @BenTheElder

@BenTheElder
Copy link
Member Author

@stevekuznetsov even just exec'ing to docker is probably fine, with a --dry-run mode to print instead?

The client libraries so far haven't really been more stable than the CLI, and being able to print out the exec call is helpful for debugging. That said the client libs are already vendored for barnacle since it can rely on the docker version underneath it.

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 12, 2018
@fejta-bot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Dec 12, 2018
@fejta-bot
Copy link

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

@k8s-ci-robot
Copy link
Contributor

@fejta-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@BenTheElder BenTheElder removed the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Jan 31, 2019
@BenTheElder BenTheElder reopened this Jan 31, 2019
@JoelSpeed
Copy link
Contributor

Is this the kind of project that would benefit from a KEP?

@krzyzacy krzyzacy changed the title Integrated bootstrap: run local Run a prowjob with podutils locally Jan 31, 2019
@krzyzacy
Copy link
Member

(Renamed the issue)

cc @munnerz @fejta

@figo
Copy link
Contributor

figo commented Feb 25, 2019

@krzyzacy @BenTheElder i believe i am doing something really close to what the PR trying to achieve.
develop and debug Prow job in my laptop (run minikube/KIND cluster in my laptop), debugging a Prow job locally is becoming:
make build # build the ci job container (has Prow podutils buildin)
kubectl create -f job.yaml deploy the ci job to local cluster

i am thinking to write a KEP, so that we could have more discussion there, any suggestion?

@BenTheElder
Copy link
Member Author

@figo I'm not sure if this needs a KEP, but that's really cool : D

@stevekuznetsov
Copy link
Contributor

@figo agreed with @BenTheElder here -- no need for a KEP, if you want to write up something quick or post a WIP PR we can talk about it in the SIG meeting and you could just contribute it to the repo :)

@BenTheElder BenTheElder removed their assignment Mar 16, 2019
@fejta
Copy link
Contributor

fejta commented Apr 9, 2019

Here's the design I would like to see: https://docs.google.com/document/d/1O9edBOAU6D_Wqq-3lFI-si2lEAJwgrEbpwU9dgDjII4/edit?usp=sharing

This does not use kind, instead it translates the prowjob into the equivalent docker container and uses the command line to run it.

/assign

@figo how are things going on your end?

@figo
Copy link
Contributor

figo commented Apr 9, 2019

Here's the design I would like to see: https://docs.google.com/document/d/1O9edBOAU6D_Wqq-3lFI-si2lEAJwgrEbpwU9dgDjII4/edit?usp=sharing

This does not use kind, instead it translates the prowjob into the equivalent docker container and uses the command line to run it.

/assign

@figo how are things going on your end?

i have not writing anything yet beside i am practicing it with KIND approach, your design doc is good place for discussions, i will join there.

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 8, 2019
@fejta-bot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Aug 7, 2019
@cjwagner
Copy link
Member

cjwagner commented Aug 8, 2019

Duplicate of #13475
Resolved by #13561

@cjwagner
Copy link
Member

cjwagner commented Aug 8, 2019

/close

@k8s-ci-robot
Copy link
Contributor

@cjwagner: Closing this issue.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/prow Issues or PRs related to prow kind/feature Categorizes issue or PR as related to a new feature. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. priority/backlog Higher priority than priority/awaiting-more-evidence.
Projects
None yet
Development

No branches or pull requests

9 participants