Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prow: deck: time hover is backwards #7098

Closed
stevekuznetsov opened this issue Mar 2, 2018 · 10 comments
Closed

prow: deck: time hover is backwards #7098

stevekuznetsov opened this issue Mar 2, 2018 · 10 comments
Assignees
Labels
area/prow Issues or PRs related to prow kind/bug Categorizes issue or PR as related to a bug.

Comments

@stevekuznetsov
Copy link
Contributor

Right now you get the full timestamp in the UI and the "N minutes ago" on hover -- seems like that should be reversed. Show the nice human-focused time and hover to get the nitty gritty timestamp.

/kind bug
/area prow
/assign @qhuynh96
/cc @BenTheElder

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. area/prow Issues or PRs related to prow labels Mar 2, 2018
@BenTheElder
Copy link
Member

BenTheElder commented Mar 2, 2018 via email

@qhuynh96
Copy link
Contributor

qhuynh96 commented Mar 2, 2018

We reversed this after a discussion about people may want to interact with the time directly (copy/paste) also you cant see full time on mobile. WDYT

@BenTheElder
Copy link
Member

What about making the timestamp format more concise and show a more detailed one / timezone etc on hover?

OTOH I could be OK with "x minutes ago" if we EG had some worker updating that every so often so it was accurate or something... As it stood "x minutes ago" didn't seem that helpful and it was difficult to make out the timestamp from hover even on fancy giant monitors 🤷‍♂️

@stevekuznetsov
Copy link
Contributor Author

Hmmm. I guess in the majority of cases displays will have the "x minutes ago" and hover to get the real time, that was just most common in what I saw elsewhere and what I expected from that background. If it's a static thing that doesn't get refreshed that isn't the end of the world but agreed if it ticks up that would be better.

@stevekuznetsov
Copy link
Contributor Author

Also agreed that the formatting could help -- right now I just want to know roughly when a job ran. Neither the old format (wrong timezone) nor the current one (huge block of text) is helping me there -- a concise version might help a lot there.

@BenTheElder
Copy link
Member

BenTheElder commented Mar 2, 2018

right now we have 'MMM DD YYYY, HH:MM:SS [GMT]ZZ', perhaps use that one for hover and something like 'HH:MM:SS' for display which is more concise even than two minutes ago. We could also try to fix hover / mobile and make the hover larger instead.

@qhuynh96
Copy link
Contributor

qhuynh96 commented Mar 2, 2018

The time is already updated every 1 min so you dont need to refresh. I dont use this much so I could not tell which way is better, defer to you, @BenTheElder, @ixdy

@ixdy
Copy link
Member

ixdy commented Mar 2, 2018

I agree that it seems a bit backwards right now, at least compared to most sites which show relative times (with a click or hover to get absolute times). To solve the mobile issue, can we also add a tap target or something which reveals the real time?

Side note, every job is showing the exact same started time right now (Mar 02 2018, 10:03:00 GMT-0800), which seems like a bug.

@ixdy
Copy link
Member

ixdy commented Mar 2, 2018

(bikeshed/soapbox: I personally do not like the "N minutes ago" timestamps, and much prefer absolute times always.)

@qhuynh96
Copy link
Contributor

qhuynh96 commented Mar 2, 2018

@ixdy @BenTheElder the bug 10:03 is due to wrong time format, should be HH:mm:ss not HH:MM:SS
MM is month

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/prow Issues or PRs related to prow kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

No branches or pull requests

5 participants