Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable NoDaemonSetScheduler alpha features in separate CI #7149

Closed
k82cn opened this issue Mar 6, 2018 · 7 comments
Closed

Enable NoDaemonSetScheduler alpha features in separate CI #7149

k82cn opened this issue Mar 6, 2018 · 7 comments
Assignees

Comments

@k82cn
Copy link
Member

k82cn commented Mar 6, 2018

In kubernetes/kubernetes#59194 (Schedule DaemonSet Pods by default scheduler), we'd like to schedule DaemonSet's pod by default scheduler instead of daemonset controller. There's no behavior changed, so I'd like to re-run the DaemonSet e2e test with this alpha feature enabled.

BTW, this's a 1.10 alpha feature; that'll be great if we can enable it in 1.10 :)

/cc @BenTheElder @krzyzacy

@BenTheElder
Copy link
Member

/assign
/assign @krzyzacy
/area jobs

@krzyzacy
Copy link
Member

krzyzacy commented Mar 6, 2018

you can enable the feature in https://k8s-testgrid.appspot.com/sig-release-1.10-blocking#gce-alpha-features-1.10

@k82cn
Copy link
Member Author

k82cn commented Mar 7, 2018

@krzyzacy , any example (e.g. PR or configuration file) on how to enable it?

@BenTheElder
Copy link
Member

@k82cn jobs/config.json and prow/config.yaml

Flipping the question though, what switches need to get enabled here? and What ginkgo focus?

@krzyzacy
Copy link
Member

krzyzacy commented Mar 7, 2018

@k82cn
Copy link
Member Author

k82cn commented Mar 7, 2018

great, let me try it :)

@k82cn
Copy link
Member Author

k82cn commented Mar 17, 2018

Alpha features are enabled and no behavior change to DaemonSet when ScheduleDaemonSetPods enabled, so we don-t need to highlight it; dependent DaemonSet's e2e test is enough.

@k82cn k82cn closed this as completed Mar 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants