Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tide status page does not indicate milestone requirements #9335

Closed
spiffxp opened this issue Sep 11, 2018 · 3 comments
Closed

tide status page does not indicate milestone requirements #9335

spiffxp opened this issue Sep 11, 2018 · 3 comments
Assignees
Labels
area/prow Issues or PRs related to prow kind/bug Categorizes issue or PR as related to a bug. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.

Comments

@spiffxp
Copy link
Member

spiffxp commented Sep 11, 2018

We use two k/k queries that have different milestone requirements, but they look as though they're the same query in the UI

screen shot 2018-09-11 at 10 04 05 am

/area prow
/kind bug
/priority important-soon

@k8s-ci-robot k8s-ci-robot added area/prow Issues or PRs related to prow kind/bug Categorizes issue or PR as related to a bug. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. labels Sep 11, 2018
@BenTheElder
Copy link
Member

This is a pretty easy fix. I can probably tackle it in the near future if nobody else does. Basically we should just need to update the javascript snippet that generates the rendered queries to handle that field and add something like:

and in one of the follow milestones:

  • milestone-v1.12

@BenTheElder
Copy link
Member

We also need to surface this in the query info on the PR page, cc @amwat @qhuynh96
Additionally, on the PR page, for the sets of missing labels, we need some way to make it clear which one relates to the milestone or not when we have multiple queries with and without milestones.

@qhuynh96
Copy link
Contributor

/assign

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/prow Issues or PRs related to prow kind/bug Categorizes issue or PR as related to a bug. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Projects
None yet
Development

No branches or pull requests

4 participants