Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

more repo cleanup #10082

Merged
merged 6 commits into from Nov 8, 2018
Merged

more repo cleanup #10082

merged 6 commits into from Nov 8, 2018

Conversation

BenTheElder
Copy link
Member

More work on attempting to make test-infra more navigable / less intimidating to glance at / cleaning out old junk:

  • remove stray .project, added a year ago in a "squash" commit and never touched since
  • move *.bzl from the root into def/
  • remove old commands.md which was slated for removal "... after 3 months or the release of kubernetes 1.10, whichever comes first."
  • move .gitattributes for phony examples out of the root and into the phony examples dir
  • move .kazelcfg.json into hack/ (open to other locations, but it doesn't need to be in the root and we have a billion files in the repo root)
  • move top level go packages (meant to be shared) to pkg/ mimic-ing other go projects and dropping two more top level dirs

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 8, 2018
@k8s-ci-robot k8s-ci-robot added area/prow Issues or PRs related to prow area/prow/hook Issues or PRs related to prow's hook component area/prow/jenkins-operator Issues or PRs related to prow's jenkins-operator component area/prow/phony Issues or PRs related to prow's phony component area/prow/plank Issues or PRs related to prow's plank component area/prow/tide Issues or PRs related to prow's tide component area/testgrid approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Nov 8, 2018
@BenTheElder BenTheElder requested review from krzyzacy and removed request for rmmh November 8, 2018 04:10
@BenTheElder BenTheElder mentioned this pull request Nov 8, 2018
Closed
@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 8, 2018
krzyzacy
krzyzacy reviewed Nov 8, 2018
View reviewed changes
Copy link
Member

@krzyzacy krzyzacy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks all good! thanks!

/lgtm
/hold

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 8, 2018
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 86f066f341ec0ab34e00e9fc7f8a5a1186c999fe

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder, krzyzacy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [BenTheElder,krzyzacy]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@BenTheElder
Copy link
Member Author

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 8, 2018
@k8s-ci-robot k8s-ci-robot merged commit 8ffc6a4 into kubernetes:master Nov 8, 2018
@BenTheElder BenTheElder deleted the even-tidier branch November 8, 2018 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krzyzacy krzyzacy krzyzacy left review comments

@fejta fejta Awaiting requested review from fejta

Assignees

@krzyzacy krzyzacy

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/prow/hook Issues or PRs related to prow's hook component area/prow/jenkins-operator Issues or PRs related to prow's jenkins-operator component area/prow/phony Issues or PRs related to prow's phony component area/prow/plank Issues or PRs related to prow's plank component area/prow/tide Issues or PRs related to prow's tide component area/prow Issues or PRs related to prow area/testgrid cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@BenTheElder @k8s-ci-robot @krzyzacy