Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Depetrify the cats. #10111

Merged
merged 1 commit into from
Nov 9, 2018
Merged

Depetrify the cats. #10111

merged 1 commit into from
Nov 9, 2018

Conversation

cjwagner
Copy link
Member

@cjwagner cjwagner commented Nov 9, 2018

fixes #10110
Adds support for /meowvie (suggestions welcome) to specifically request GIF images.

/kind bug
/cc @BenTheElder @krzyzacy @fejta

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. area/prow Issues or PRs related to prow size/L Denotes a PR that changes 100-499 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Nov 9, 2018
@krzyzacy
Copy link
Member

krzyzacy commented Nov 9, 2018

/assign @michelle192837

@krzyzacy
Copy link
Member

krzyzacy commented Nov 9, 2018

@michelle192837 please approve this P0 fix!

fejta
fejta approved these changes Nov 9, 2018
View reviewed changes
Copy link
Contributor

@fejta fejta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/purr
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 9, 2018
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 7bb2151390ef8862e1b65265a9e351ddb66b99a1

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cjwagner, fejta

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ibzib
Copy link
Contributor

ibzib commented Nov 9, 2018

this pr needs a /meow

@ibzib
Copy link
Contributor

ibzib commented Nov 9, 2018

/meow

@k8s-ci-robot
Copy link
Contributor

@ibzib: cat image

In response to this:

/meow

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@fejta
Copy link
Contributor

fejta commented Nov 9, 2018

second "cat biting my finger" pic in as many days

@k8s-ci-robot k8s-ci-robot merged commit 1a84354 into kubernetes:master Nov 9, 2018
@cjwagner cjwagner deleted the mandrake-root branch November 9, 2018 18:41
@cjwagner cjwagner mentioned this pull request Nov 9, 2018
Merged
@cjwagner
Copy link
Member Author

cjwagner commented Nov 9, 2018

/meowvie space

@k8s-ci-robot
Copy link
Contributor

@cjwagner: cat image

In response to this:

/meowvie space

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@cjwagner
Copy link
Member Author

cjwagner commented Nov 9, 2018

/meowvie clothes

@k8s-ci-robot
Copy link
Contributor

@cjwagner: cat image

In response to this:

/meowvie clothes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@cjwagner
Copy link
Member Author

cjwagner commented Nov 9, 2018

/meowvie

@k8s-ci-robot
Copy link
Contributor

@cjwagner: cat image

In response to this:

/meowvie

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@BenTheElder
Copy link
Member

/meowvie space

@k8s-ci-robot
Copy link
Contributor

@BenTheElder: cat image

In response to this:

/meowvie space

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@BenTheElder
Copy link
Member

/meowvie sinks

@k8s-ci-robot
Copy link
Contributor

@BenTheElder: Bad category. Please see https://api.thecatapi.com/api/categories/list

In response to this:

/meowvie sinks

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@BenTheElder
Copy link
Member

sinks is a category? https://api.thecatapi.com/api/categories/list :(

@BenTheElder BenTheElder mentioned this pull request Nov 9, 2018
Closed
@spiffxp
Copy link
Member

spiffxp commented Nov 9, 2018

oh my god what is wrong with you people

I mean

/meowvie space

@k8s-ci-robot
Copy link
Contributor

@spiffxp: cat image

In response to this:

oh my god what is wrong with you people

I mean

/meowvie space

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@BenTheElder
Copy link
Member

/meowvie sinks

@k8s-ci-robot
Copy link
Contributor

@BenTheElder: Bad category. Please see https://api.thecatapi.com/api/categories/list

In response to this:

/meowvie sinks

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@neolit123
Copy link
Member

/meowvie

@k8s-ci-robot
Copy link
Contributor

@neolit123: cat image

In response to this:

/meowvie

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@neolit123
Copy link
Member

IT"S CATZILLA!!!

@diazjf
Copy link

diazjf commented Nov 9, 2018

Possibly the best PR I have ever seen! Good Job Everyone 💯

@micw523
Copy link
Contributor

micw523 commented Nov 9, 2018

/meowvie psychedelic

@k8s-ci-robot
Copy link
Contributor

@micw523: Bad category. Please see https://api.thecatapi.com/api/categories/list

In response to this:

/meowvie psychedelic

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@csantanapr
Copy link
Member

/meowvie sunglasses

@k8s-ci-robot
Copy link
Contributor

@csantanapr: Bad category. Please see https://api.thecatapi.com/api/categories/list

In response to this:

/meowvie sunglasses

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@csantanapr
Copy link
Member

/meowvie breaded

@k8s-ci-robot
Copy link
Contributor

@csantanapr: Bad category. Please see https://api.thecatapi.com/api/categories/list

In response to this:

/meowvie breaded

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@csantanapr
Copy link
Member

I think this thing might have a bug I used sunglasses and breaded both are in the categories in https://api.thecatapi.com/api/categories/list

@csantanapr
Copy link
Member

/meowvie

@k8s-ci-robot
Copy link
Contributor

@csantanapr: cat image

In response to this:

/meowvie

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@csantanapr
Copy link
Member

/meowvie hats

@k8s-ci-robot
Copy link
Contributor

@csantanapr: cat image

In response to this:

/meowvie hats

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@micw523
Copy link
Contributor

micw523 commented Nov 9, 2018

@csantanapr @krzyzacy
I went to check which categories are actually available. Those are 5, 6, 15, 9, 3, 1, 10, 14, 2, 4, 7. The api list is out of date.
/meowvie clothes

@k8s-ci-robot
Copy link
Contributor

@micw523: cat image

In response to this:

@csantanapr @krzyzacy
I went to check which categories are actually available. Those are 5, 6, 15, 9, 3, 1, 10, 14, 2, 4, 7. The api list is out of date.
/meowvie clothes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@micw523
Copy link
Contributor

micw523 commented Nov 9, 2018

/shrug

@k8s-ci-robot k8s-ci-robot added the ¯\_(ツ)_/¯ ¯\\\_(ツ)_/¯ label Nov 9, 2018
@micw523 micw523 mentioned this pull request Nov 10, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fejta fejta fejta approved these changes

@BenTheElder BenTheElder Awaiting requested review from BenTheElder

@krzyzacy krzyzacy Awaiting requested review from krzyzacy

Assignees

@michelle192837 michelle192837

@fejta fejta

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/prow Issues or PRs related to prow cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. ¯\_(ツ)_/¯ ¯\\\_(ツ)_/¯
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cat plugin is unusable.