Modify kubernetes_verify scenario to pass env vars into job

[cblecker]

I will be VERY HAPPY when we can get rid of this scenario. Until then, I had to modify it and create a couple new flags to be able to pass options into the job.

Extra eyes on the python might be required, as it's not my strongest language.

/assign @krzyzacy

[krzyzacy]

How about let's try to make the -podutil version pass? :-)

I don't think we want to touch this scenario anymore, we should migrate and rip the python script :-)

[krzyzacy]

https://gubernator.k8s.io/build/kubernetes-jenkins/pr-logs/pull/72255/pull-kubernetes-verify-podutil/7

you probably know, any idea why https://github.com/kubernetes/kubernetes/blob/28b965a8c0dcc941dad94e2ceeab72049a173527/hack/verify-godep-licenses.sh#L24 is resolved to /master instead of master from https://github.com/kubernetes/test-infra/blob/master/config/jobs/kubernetes/sig-testing/verify.yaml#L54-L55？

[cblecker]

It can’t resolve the what the upstream remote is, because it’s not a proper clone when you do it with podutils

[cblecker]

https://github.com/kubernetes/kubernetes/blob/d257ee9bfdd8e32138d6c906ec94411b8e1d62fd/hack/lib/util.sh#L361

https://github.com/kubernetes/kubernetes/blob/d257ee9bfdd8e32138d6c906ec94411b8e1d62fd/hack/lib/util.sh#L509

[krzyzacy]

doh...

which means I need to add remote and do a fetch?

[cblecker]

I think so.. the script is trying to compare if there are changes locally compared to upstream/master

[BenTheElder]

/pony this is fine

[k8s-ci-robot]

@BenTheElder:

In response to this:

/pony this is fine

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[cblecker]

I fixed the lint error here. If we don't have a clear path to podutils for the verify job, I'd like to merge this.. it will shave up to 30 minutes off the verify job :)

[BenTheElder]

the friday before christmas is the best time to change test-infra python job scripts! with docker, bash, python and more! 🎉
/lgtm
/approve
/hold cancel
/this-is-fine
/sig this-is-fine
/pony this is fine
/woof
/meow space
Thanks Christoph 🙃

[k8s-ci-robot]

@BenTheElder:

In response to this:

the friday before christmas is the best time to change test-infra python job scripts! with docker, bash, python and more! 🎉
/lgtm
/approve
/hold cancel
/this-is-fine
/sig this-is-fine
/pony this is fine
/woof
/meow space
Thanks Christoph 🙃

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[k8s-ci-robot]

@BenTheElder:

In response to this:

the friday before christmas is the best time to change test-infra python job scripts! with docker, bash, python and more! 🎉
/lgtm
/approve
/hold cancel
/this-is-fine
/sig this-is-fine
/pony this is fine
/woof
/meow space
Thanks Christoph 🙃

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[k8s-ci-robot]

@BenTheElder:

In response to this:

the friday before christmas is the best time to change test-infra python job scripts! with docker, bash, python and more! 🎉
/lgtm
/approve
/hold cancel
/this-is-fine
/sig this-is-fine
/pony this is fine
/woof
/meow space
Thanks Christoph 🙃

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[k8s-ci-robot]

LGTM label has been added.

Git tree hash: e1c48cf92e122178354a5b1d0b1ab2d27b54e5f5

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder, cblecker

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [BenTheElder]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[k8s-ci-robot]

@cblecker: Updated the job-config configmap using the following files:

• key verify.yaml using file config/jobs/kubernetes/sig-testing/verify.yaml
• key generated-security-jobs.yaml using file config/jobs/kubernetes-security/generated-security-jobs.yaml

In response to this:

I will be VERY HAPPY when we can get rid of this scenario. Until then, I had to modify it and create a couple new flags to be able to pass options into the job.

Extra eyes on the python might be required, as it's not my strongest language.

/assign @krzyzacy

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.