Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to go1.11.5 and go1.10.8 #10957

Merged
merged 3 commits into from Jan 25, 2019
Merged

Update to go1.11.5 and go1.10.8 #10957

merged 3 commits into from Jan 25, 2019

Conversation

ixdy
Copy link
Member

@ixdy ixdy commented Jan 25, 2019

Also use bazel 0.21.0 for testing the Kubernetes master branch. (It's been fine on test-infra, and I've also used bazel 0.21.0 locally for quite some time.)

x-ref kubernetes/kubernetes#73238

I can bump kubekins-test and kubekins-e2e in this PR if we'd like, too.

/assign @BenTheElder @cblecker

@ixdy
Update to go1.11.5 and go1.10.8
cc5d6ec 
Also use bazel 0.21.0 for testing the Kubernetes master branch.
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 25, 2019
@k8s-ci-robot k8s-ci-robot added area/images sig/testing Categorizes an issue or PR as relevant to SIG Testing. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jan 25, 2019
@cblecker
Copy link
Member

/lgtm
/hold

Should k/k go in first?

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Jan 25, 2019
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: a17e4c746fec43ae69354589beb976b37c16ea13

@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. area/config Issues or PRs related to code in /config area/scenarios and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 25, 2019
@ixdy
Copy link
Member Author

ixdy commented Jan 25, 2019

Built an new kubekins-test image and update its references (we're close to being able to remove that one though, right @krzyzacy?), as well as kubekins-e2e.

I also built and pushed a new gcloud-in-go image, but I didn't update its uses anywhere since I'm not sure how safe that is (and a bunch of jobs seem to use wildly different versions of it).

@ixdy
Copy link
Member Author

ixdy commented Jan 25, 2019

cc @amwat

BenTheElder
BenTheElder approved these changes Jan 25, 2019
View reviewed changes
Copy link
Member

@BenTheElder BenTheElder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve
/hold

@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 3cc472863a3bbdfd22160fa5e608a66e654f3f73

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 25, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder, ixdy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ixdy
Copy link
Member Author

ixdy commented Jan 25, 2019

/hold cancel
:shipit:

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 25, 2019
@k8s-ci-robot k8s-ci-robot merged commit c294be2 into kubernetes:master Jan 25, 2019
@k8s-ci-robot
Copy link
Contributor

@ixdy: Updated the job-config configmap using the following files:

  • key cloud-provider-vsphere-presubmits.yaml using file config/jobs/kubernetes/cloud-provider-vsphere/cloud-provider-vsphere-presubmits.yaml
  • key k8s-upgrade-gce.yaml using file config/jobs/kubernetes/sig-cluster-lifecycle/k8s-upgrade-gce.yaml
  • key janitors.yaml using file config/jobs/kubernetes/test-infra/janitors.yaml
  • key kubeflow-postsubmits.yaml using file config/jobs/kubeflow/kubeflow-postsubmits.yaml
  • key structured-merge-diff-ci.yaml using file config/jobs/kubernetes-sigs/structured-merge-diff/structured-merge-diff-ci.yaml
  • key ci-e2e-gce-netd.yaml using file config/jobs/kubernetes/sig-network/ci-e2e-gce-netd.yaml
  • key verify.yaml using file config/jobs/kubernetes/sig-testing/verify.yaml
  • key sig-gcp-gce-config.yaml using file config/jobs/kubernetes/sig-gcp/sig-gcp-gce-config.yaml
  • key containerd.yaml using file config/jobs/kubernetes/sig-node/containerd.yaml
  • key sig-storage-gce-config.yaml using file config/jobs/kubernetes/sig-storage/sig-storage-gce-config.yaml
  • key test-infra-presubmits.yaml using file config/jobs/kubernetes/test-infra/test-infra-presubmits.yaml
  • key sig-storage-local-static-provisioner-trusted.yaml using file config/jobs/kubernetes-sigs/sig-storage-local-static-provisioner/sig-storage-local-static-provisioner-trusted.yaml
  • key sig-storage-local-static-provisioner.yaml using file config/jobs/kubernetes-sigs/sig-storage-local-static-provisioner/sig-storage-local-static-provisioner.yaml
  • key sig-gcp-windows.yaml using file config/jobs/kubernetes/sig-gcp/sig-gcp-windows.yaml
  • key sig-instrumentation-config.yaml using file config/jobs/kubernetes/sig-instrumentation/sig-instrumentation-config.yaml
  • key gce-conformance.yaml using file config/jobs/kubernetes/sig-gcp/gce-conformance.yaml
  • key charts.yaml using file config/jobs/helm/charts/charts.yaml
  • key cluster-api-provider-aws-presubmits.yaml using file config/jobs/kubernetes-sigs/cluster-api-provider-aws/cluster-api-provider-aws-presubmits.yaml
  • key kind-postsubmits.yaml using file config/jobs/kubernetes-sigs/kind/kind-postsubmits.yaml
  • key kubeadm-upgrade.yaml using file config/jobs/kubernetes/sig-cluster-lifecycle/kubeadm-upgrade.yaml
  • key test-infra-postsubmits.yaml using file config/jobs/kubernetes/test-infra/test-infra-postsubmits.yaml
  • key containerd-cri-presubmit-jobs.yaml using file config/jobs/containerd/cri/containerd-cri-presubmit-jobs.yaml
  • key kustomize-config.yaml using file config/jobs/kubernetes-sigs/kustomize/kustomize-config.yaml
  • key sig-network-misc.yaml using file config/jobs/kubernetes/sig-network/sig-network-misc.yaml
  • key sig-node-presubmit.yaml using file config/jobs/kubernetes/sig-node/sig-node-presubmit.yaml
  • key bazel-build-test.yaml using file config/jobs/kubernetes/sig-testing/bazel-build-test.yaml
  • key coverage.yaml using file config/jobs/kubernetes/sig-testing/coverage.yaml
  • key presubmits.yaml using file config/jobs/kubernetes-sigs/kube-storage-version-migrator/presubmits.yaml
  • key structured-merge-diff-presubmits.yaml using file config/jobs/kubernetes-sigs/structured-merge-diff/structured-merge-diff-presubmits.yaml
  • key sig-gcp-gpu-gce.yaml using file config/jobs/kubernetes/sig-gcp/gpu/sig-gcp-gpu-gce.yaml
  • key sig-gcp-gke-config.yaml using file config/jobs/kubernetes/sig-gcp/sig-gcp-gke-config.yaml
  • key kops-config.yaml using file config/jobs/kubernetes/kops/kops-config.yaml
  • key sig-gcp-gpu-upgrade-downgrade.yaml using file config/jobs/kubernetes/sig-gcp/gpu/sig-gcp-gpu-upgrade-downgrade.yaml
  • key sig-scalability-periodic-jobs.yaml using file config/jobs/kubernetes/sig-scalability/sig-scalability-periodic-jobs.yaml
  • key cadvisor.yaml using file config/jobs/cadvisor/cadvisor.yaml
  • key gke-test-containerd.yaml using file config/jobs/gke/containerd/gke-test-containerd.yaml
  • key gcp-compute-persistent-disk-csi-driver-postsubmits.yaml using file config/jobs/kubernetes-sigs/gcp-compute-persistent-disk-csi-driver/gcp-compute-persistent-disk-csi-driver-postsubmits.yaml
  • key sig-windows-config.yaml using file config/jobs/kubernetes-sigs/sig-windows/sig-windows-config.yaml
  • key sig-scalability-release-blocking-jobs.yaml using file config/jobs/kubernetes/sig-scalability/sig-scalability-release-blocking-jobs.yaml
  • key spark-config.yaml using file config/jobs/apache-spark-on-k8s/spark-integration/spark-config.yaml
  • key service-catalog-presubmits.yaml using file config/jobs/kubernetes-incubator/service-catalog/service-catalog-presubmits.yaml
  • key kubeadm.yaml using file config/jobs/kubernetes/sig-cluster-lifecycle/kubeadm.yaml
  • key local-e2e-containerized.yaml using file config/jobs/kubernetes/sig-node/local-e2e-containerized.yaml
  • key k8s-multicluster-ingress-config.yaml using file config/jobs/GoogleCloudPlatform/k8s-multicluster-ingress/k8s-multicluster-ingress-config.yaml
  • key config.yaml using file config/jobs/kubernetes-sigs/gcp-compute-persistent-disk-csi-driver/config.yaml
  • key sig-autoscaling-config.yaml using file config/jobs/kubernetes/sig-autoscaling/sig-autoscaling-config.yaml
  • key release-config.yaml using file config/jobs/kubernetes/release/release-config.yaml
  • key k8s-aws-eks-periodics.yaml using file config/jobs/kubernetes/sig-aws/eks/k8s-aws-eks-periodics.yaml
  • key sig-cli-config.yaml using file config/jobs/kubernetes/sig-cli/sig-cli-config.yaml
  • key kubeadm-x-on-y.yaml using file config/jobs/kubernetes/sig-cluster-lifecycle/kubeadm-x-on-y.yaml
  • key generated-security-jobs.yaml using file config/jobs/kubernetes-security/generated-security-jobs.yaml
  • key cluster-api-provider-gcp-presubmits.yaml using file config/jobs/kubernetes-sigs/cluster-api-provider-gcp/cluster-api-provider-gcp-presubmits.yaml
  • key kind.yaml using file config/jobs/kubernetes-sigs/kind/kind.yaml
  • key cluster-registry-config.yaml using file config/jobs/kubernetes/cluster-registry/cluster-registry-config.yaml
  • key sig-gcp-gpu-autoscaling.yaml using file config/jobs/kubernetes/sig-gcp/gpu/sig-gcp-gpu-autoscaling.yaml
  • key k8s-aws-eks-presubmits.yaml using file config/jobs/kubernetes/sig-aws/eks/k8s-aws-eks-presubmits.yaml
  • key kubeflow-presubmits.yaml using file config/jobs/kubeflow/kubeflow-presubmits.yaml
  • key aws-alb-ingress-controller-presubmits.yaml using file config/jobs/kubernetes-sigs/aws-alb-ingress-controller/aws-alb-ingress-controller-presubmits.yaml
  • key kind-presubmits.yaml using file config/jobs/kubernetes-sigs/kind/kind-presubmits.yaml
  • key sig-api-machinery-config.yaml using file config/jobs/kubernetes/sig-api-machinery/sig-api-machinery-config.yaml
  • key sig-gcp-gpu-gke.yaml using file config/jobs/kubernetes/sig-gcp/gpu/sig-gcp-gpu-gke.yaml
  • key sig-scalability-presubmit-jobs.yaml using file config/jobs/kubernetes/sig-scalability/sig-scalability-presubmit-jobs.yaml
  • key test-infra-periodics.yaml using file config/jobs/kubernetes/test-infra/test-infra-periodics.yaml
  • key cluster-api-provider-azure-presubmits.yaml using file config/jobs/kubernetes-sigs/cluster-api-provider-azure/cluster-api-provider-azure-presubmits.yaml
  • key poseidon-config.yaml using file config/jobs/kubernetes-sigs/poseidon/poseidon-config.yaml
  • key cloud-provider-azure-config.yaml using file config/jobs/kubernetes/cloud-provider-azure/cloud-provider-azure-config.yaml
  • key sig-aws-config.yaml using file config/jobs/kubernetes/sig-aws/sig-aws-config.yaml
  • key node-kubelet.yaml using file config/jobs/kubernetes/sig-node/node-kubelet.yaml
  • key aws-ebs-csi-driver-presubmits.yaml using file config/jobs/kubernetes-sigs/aws-ebs-csi-driver/aws-ebs-csi-driver-presubmits.yaml
  • key cluster-api-provider-aws-ci.yaml using file config/jobs/kubernetes-sigs/cluster-api-provider-aws/cluster-api-provider-aws-ci.yaml
  • key k8s-upgrade-gke.yaml using file config/jobs/kubernetes/sig-cluster-lifecycle/k8s-upgrade-gke.yaml
  • key sig-gcp-gpu-presubmit.yaml using file config/jobs/kubernetes/sig-gcp/gpu/sig-gcp-gpu-presubmit.yaml
  • key sig-apps-config.yaml using file config/jobs/kubernetes/sig-apps/sig-apps-config.yaml
  • key sig-aws-presubmits.yaml using file config/jobs/kubernetes/sig-aws/sig-aws-presubmits.yaml
  • key godeps.yaml using file config/jobs/kubernetes/sig-testing/godeps.yaml
  • key typecheck.yaml using file config/jobs/kubernetes/sig-testing/typecheck.yaml
  • key cluster-api-provider-digitalocean-presubmits.yaml using file config/jobs/kubernetes-sigs/cluster-api-provider-digitalocean/cluster-api-provider-digitalocean-presubmits.yaml
  • key cluster-api-provider-vsphere-presubmits.yaml using file config/jobs/kubernetes-sigs/cluster-api-provider-vsphere/cluster-api-provider-vsphere-presubmits.yaml
  • key cloud-provider-aws-config.yaml using file config/jobs/kubernetes/cloud-provider-aws/cloud-provider-aws-config.yaml
  • key generated.yaml using file config/jobs/kubernetes/generated/generated.yaml
  • key ingress-gce-e2e.yaml using file config/jobs/kubernetes/sig-network/ingress-gce-e2e.yaml
  • key node-docker.yaml using file config/jobs/kubernetes/sig-node/node-docker.yaml
  • key local-e2e.yaml using file config/jobs/kubernetes/sig-testing/local-e2e.yaml
  • key cluster-api-provider-openstack-presubmits.yaml using file config/jobs/kubernetes-sigs/cluster-api-provider-openstack/cluster-api-provider-openstack-presubmits.yaml
  • key cluster-api-presubmits.yaml using file config/jobs/kubernetes-sigs/cluster-api/cluster-api-presubmits.yaml
  • key cloud-provider-openstack-config.yaml using file config/jobs/kubernetes/cloud-provider-openstack/cloud-provider-openstack-config.yaml
  • key sig-cluster-lifecycle-misc.yaml using file config/jobs/kubernetes/sig-cluster-lifecycle/sig-cluster-lifecycle-misc.yaml

In response to this:

Also use bazel 0.21.0 for testing the Kubernetes master branch. (It's been fine on test-infra, and I've also used bazel 0.21.0 locally for quite some time.)

x-ref kubernetes/kubernetes#73238

I can bump kubekins-test and kubekins-e2e in this PR if we'd like, too.

/assign @BenTheElder @cblecker

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@cblecker cblecker mentioned this pull request Jan 27, 2019
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BenTheElder BenTheElder BenTheElder approved these changes

@stevekuznetsov stevekuznetsov Awaiting requested review from stevekuznetsov

Assignees

@BenTheElder BenTheElder

@cblecker cblecker

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/images area/scenarios cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ixdy @cblecker @k8s-ci-robot @BenTheElder