Improve Prow development docs a bit. #12245
Conversation
k8s-ci-robot
added
cncf-cla: yes
k8s-ci-robot
added
size/M
| ```shell | ||
| # export PROW_REPO_OVERRIDE=gcr.io/k8s-prow # optionally override project | ||
| push.sh # Build and push the current repo state. | ||
| bump.sh --list # Choose a recent published version |
There was a problem hiding this comment.
This is the only part of the "How to update the cluster" section that I actually updated. The rest I just moved.
There was a problem hiding this comment.
Is this using @Katharine 's new tool?
There was a problem hiding this comment.
No, we just moved the ./bump.sh --push functionality into the ./push.sh script AFAICT.
prow/build_test_update.md
Outdated
| **TODO**(cjwagner): Unify and document how to run prow components locally. | ||
| ### How to test a plugin | ||
|
|
||
| If you are making changes to a Prow plugin you can test the new behavior by sending fake webhook events with [`phony`](/prow/cmd/phony#phony). |
There was a problem hiding this comment.
Maybe
sending fake webhooks to `hook` with `phony`
?
| ```shell | ||
| # export PROW_REPO_OVERRIDE=gcr.io/k8s-prow # optionally override project | ||
| push.sh # Build and push the current repo state. | ||
| bump.sh --list # Choose a recent published version |
There was a problem hiding this comment.
Is this using @Katharine 's new tool?
prow/build_test_update.md
Outdated
| bazel run //prow/cluster:hook.apply # just update hook | ||
|
|
||
| # This is equivalent to doing the following with kubectl directly: | ||
| kubectl config use-context gke_my-project_my-zone_my-cluster |
There was a problem hiding this comment.
Could we de-GKE-ify this?
There was a problem hiding this comment.
Sure. What do you suggest?
There was a problem hiding this comment.
I switched to my-k8s-cluster-context
prow/jobs.md
Outdated
| Jobs that run will always post a status context to the commit under test in GitHub. | ||
| Jobs that run conditionally but do not match the content of the pull request will | ||
| _not_ post "Skipped" status contexts to the pull request. | ||
| Presubmits that do not have `skip_report: true` will always post a status context to the commit under test in GitHub. |
There was a problem hiding this comment.
nit: text wrapping length
There was a problem hiding this comment.
Technically now postsubmits can publish
There was a problem hiding this comment.
Could we flip the negative here to have the common case first?
Jobs will post a status context in GitHub to the commit under test, unless the job is configured with `skip_report: true`
There was a problem hiding this comment.
Done.
The text wrapping still displays correctly if we don't manually manage the line length. I'm not a fan of shuffling paragraph text around when I add a few words to the first sentence so whenever I touch markdown text that manually manages line length I switch it to long lines and let GH manage the wrapping.
|
/lgtm |
|
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 2f8412c50efe6df74b67ca88e47c03280b1e171d
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cjwagner, stevekuznetsov The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/assign @stevekuznetsov @fejta