Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Service Catalog presubmit jobs to use the decorator pattern #12911

Merged
merged 1 commit into from Jun 5, 2019
Merged

Change Service Catalog presubmit jobs to use the decorator pattern #12911

merged 1 commit into from Jun 5, 2019

Conversation

mszostok
Copy link
Contributor

@mszostok mszostok commented Jun 5, 2019

Description

  • Change Service Catalog presubmit jobs to use the decorator pattern instead of deprecated boostrap.py script

More info you can find in this comment: kubernetes-retired/service-catalog#2652 (comment)

/cc @jberkhahn

@k8s-ci-robot
Copy link
Contributor

Welcome @mszostok!

It looks like this is your first PR to kubernetes/test-infra 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/test-infra has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. area/config Issues or PRs related to code in /config sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Jun 5, 2019
@jberkhahn
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 5, 2019
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 327318f8f96f45cccd8753d3722a501f9c5d77b9

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jberkhahn, mszostok

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 5, 2019
@k8s-ci-robot k8s-ci-robot merged commit 4f606c2 into kubernetes:master Jun 5, 2019
@k8s-ci-robot
Copy link
Contributor

@mszostok: Updated the job-config configmap in namespace default using the following files:

  • key service-catalog-presubmits.yaml using file config/jobs/kubernetes-sigs/service-catalog/service-catalog-presubmits.yaml

In response to this:

Description

  • Change Service Catalog presubmit jobs to use the decorator pattern instead of deprecated boostrap.py script

More info you can find in this comment: kubernetes-retired/service-catalog#2652 (comment)

/cc @jberkhahn

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mszostok mszostok deleted the fix-sc-repo-url branch June 5, 2019 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants