Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add config for enabling multi-zone e2e test. #13595

Merged
merged 1 commit into from
Jul 25, 2019
Merged

Add config for enabling multi-zone e2e test. #13595

merged 1 commit into from
Jul 25, 2019

Conversation

nilo19
Copy link
Member

@nilo19 nilo19 commented Jul 25, 2019

Add config for enabling multi-zone e2e test.

/sig azure

@k8s-ci-robot k8s-ci-robot added area/provider/azure Issues or PRs related to azure provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 25, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @nilo19. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 25, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: nilo19
To complete the pull request process, please assign khenidak
You can assign the PR to them by writing /assign @khenidak in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added area/config Issues or PRs related to code in /config sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Jul 25, 2019
@spiffxp
Copy link
Member

spiffxp commented Jul 25, 2019

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 25, 2019
feiskyer
feiskyer reviewed Jul 25, 2019
View reviewed changes
Copy link
Member

@feiskyer feiskyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

would approve after kubernetes-sigs/cloud-provider-azure#196 got merged.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 25, 2019
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: f029da0246327a5af72dc7ed68c5b7ef5c8a4a0c

@k8s-ci-robot k8s-ci-robot merged commit 5a99445 into kubernetes:master Jul 25, 2019
@k8s-ci-robot
Copy link
Contributor

@nilo19: Updated the job-config configmap in namespace default using the following files:

  • key cloud-provider-azure-config.yaml using file config/jobs/kubernetes/cloud-provider-azure/cloud-provider-azure-config.yaml

In response to this:

Add config for enabling multi-zone e2e test.

/sig azure

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@feiskyer
Copy link
Member

/approve

@nilo19 nilo19 mentioned this pull request Aug 19, 2019
Closed
6 tasks
@nilo19 nilo19 deleted the t-qini-add_config_for_multi_zones_e2e_test branch August 17, 2020 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@feiskyer feiskyer feiskyer left review comments

@brendandburns brendandburns Awaiting requested review from brendandburns

Assignees

@feiskyer feiskyer

Labels
area/config Issues or PRs related to code in /config area/provider/azure Issues or PRs related to azure provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@nilo19 @k8s-ci-robot @spiffxp @feiskyer