-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating Boskos to hold the lock when config is being synced #13990
Conversation
/cc @amwat |
/test pull-test-infra-bazel |
46ea3f4
to
1987cd6
Compare
/assign @krzyzacy |
rebase? |
Updated code to only call sync when config is updated to reduce performance impact.
1987cd6
to
83bc54b
Compare
/lgtm |
LGTM label has been added. Git tree hash: 5acf0df801b4e340e43faacd91f0024a1da74058
|
Can we use the same logic here as for Prow config? I'm ok if that means preferring this approach to the existing one, I'd just like to see parity |
I actually look at using the same mechanism, but prow's is really hard coded to Prow's config and refactoring should be done in different PR. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: krzyzacy, sebastienvas The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
It was possible to get an issue where the storage was being updated while resources were being updated from Boskos.
Also updated boskos to only sync config when the config is being changed. This means that changes in config map will be loaded faster, and we will not lock the storage every 10 minutes.