Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add image pushing for CAPA and CAPG #14284

Merged
merged 1 commit into from Sep 11, 2019
Merged

Add image pushing for CAPA and CAPG #14284

merged 1 commit into from Sep 11, 2019

Conversation

vincepri
Copy link
Member

Signed-off-by: Vince Prignano vincepri@vmware.com

/assign @detiber @Katharine

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 11, 2019
@detiber
Copy link
Member

detiber commented Sep 11, 2019

/hold pending the cloudbuild.yaml files being added to the referenced repos.

@vincepri
Copy link
Member Author

CAPG: kubernetes-sigs/cluster-api-provider-gcp#146
CAPA: kubernetes-sigs/cluster-api-provider-aws#1123

@vincepri
Add image pushing for CAPA and CAPG
6c9a8cd 
Signed-off-by: Vince Prignano <vincepri@vmware.com>
@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Sep 11, 2019
Katharine
Katharine approved these changes Sep 11, 2019
View reviewed changes
Copy link
Member

@Katharine Katharine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/hold
as above, but actually working this time

@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 46d5f69da806f60ed26718381de3c22d33515c2d

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Katharine, vincepri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 11, 2019
@vincepri
Copy link
Member Author

Related PRs have been merged !

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 11, 2019
@k8s-ci-robot k8s-ci-robot merged commit 72663f1 into kubernetes:master Sep 11, 2019
@k8s-ci-robot
Copy link
Contributor

@vincepri: Updated the job-config configmap in namespace default using the following files:

  • key k8s-staging-cluster-api.yaml using file config/jobs/image-pushing/k8s-staging-cluster-api.yaml

In response to this:

Signed-off-by: Vince Prignano vincepri@vmware.com

/assign @detiber @Katharine

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added this to the v1.16 milestone Sep 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Katharine Katharine Katharine approved these changes

@cjwagner cjwagner Awaiting requested review from cjwagner

@michelle192837 michelle192837 Awaiting requested review from michelle192837

Assignees

@Katharine Katharine

@detiber detiber

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.16
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@vincepri @detiber @k8s-ci-robot @Katharine