-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
External-DNS image pushing #15625
External-DNS image pushing #15625
Conversation
/assign @Katharine @bowei |
/assign @chases2 @michelle192837 |
/lgtm |
@njuettner Sorry for the late reply. Just curious on what this image will eventually be used for? |
@rramkumar1 We moved external-dns from kubernetes-incubator to kubernetes-sigs some weeks ago. Currently we do not have any pipeline which we can use to build our docker images. This will be used in this repo: https://github.com/kubernetes-sigs/external-dns. We already merged: kubernetes/k8s.io#479. |
@njuettner Thanks for the context. /approve |
@chases2 can you please take a look again? 🙏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chases2, MrHohn, njuettner, rramkumar1 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@njuettner: Updated the
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Allowing to push external-dns images