Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

External-DNS image pushing #15625

Merged
merged 1 commit into from
Jan 6, 2020
Merged

Conversation

njuettner
Copy link
Member

Allowing to push external-dns images

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 17, 2019
@k8s-ci-robot k8s-ci-robot added area/config Issues or PRs related to code in /config area/testgrid sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Dec 17, 2019
@njuettner
Copy link
Member Author

/assign @Katharine @bowei

@njuettner
Copy link
Member Author

/assign @chases2 @michelle192837

@chases2
Copy link
Contributor

chases2 commented Jan 2, 2020

/lgtm
I'd like some input from the sig-network owners on this
/assign @rramkumar1 @MrHohn

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 2, 2020
@rramkumar1
Copy link
Contributor

@njuettner Sorry for the late reply. Just curious on what this image will eventually be used for?

@njuettner
Copy link
Member Author

@rramkumar1 We moved external-dns from kubernetes-incubator to kubernetes-sigs some weeks ago. Currently we do not have any pipeline which we can use to build our docker images. This will be used in this repo: https://github.com/kubernetes-sigs/external-dns.

We already merged: kubernetes/k8s.io#479.

@rramkumar1
Copy link
Contributor

@njuettner Thanks for the context.

/approve

@njuettner
Copy link
Member Author

@chases2 can you please take a look again? 🙏

Copy link
Member

@MrHohn MrHohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chases2, MrHohn, njuettner, rramkumar1

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 6, 2020
@k8s-ci-robot k8s-ci-robot merged commit ee8aa2f into kubernetes:master Jan 6, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.18 milestone Jan 6, 2020
@k8s-ci-robot
Copy link
Contributor

@njuettner: Updated the job-config configmap in namespace default at cluster default using the following files:

  • key k8s-staging-external-dns.yaml using file config/jobs/image-pushing/k8s-staging-external-dns.yaml

In response to this:

Allowing to push external-dns images

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/testgrid cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants