Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kops - cleanup presubmit job definitions #15674

Merged
merged 1 commit into from
Dec 23, 2019
Merged

Kops - cleanup presubmit job definitions #15674

merged 1 commit into from
Dec 23, 2019

Conversation

rifelpet
Copy link
Member

  • Use make targets when applicable
  • Use quotes consistently
  • Remove unnecessary newlines

@rifelpet
Kops - cleanup presubmit job definitions
ff942f2 
* Use make targets when applicable
* Use quotes consistently
* Remove unnecessary newlines
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 23, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rifelpet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 23, 2019
@k8s-ci-robot k8s-ci-robot added area/config Issues or PRs related to code in /config sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Dec 23, 2019
@rifelpet
Copy link
Member Author

/cc @geojaz @joshbranham
@hakman

@joshbranham
Copy link

All for moving to the make targets
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 23, 2019
@k8s-ci-robot k8s-ci-robot merged commit 8a1005f into kubernetes:master Dec 23, 2019
@k8s-ci-robot k8s-ci-robot added this to the v1.18 milestone Dec 23, 2019
@k8s-ci-robot
Copy link
Contributor

@rifelpet: Updated the job-config configmap in namespace default at cluster default using the following files:

  • key kops-config.yaml using file config/jobs/kubernetes/kops/kops-config.yaml

In response to this:

  • Use make targets when applicable
  • Use quotes consistently
  • Remove unnecessary newlines

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rifelpet rifelpet mentioned this pull request Dec 23, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshbranham joshbranham Awaiting requested review from joshbranham

@robinpercy robinpercy Awaiting requested review from robinpercy

@geojaz geojaz Awaiting requested review from geojaz

Assignees

@joshbranham joshbranham

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.18
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rifelpet @k8s-ci-robot @joshbranham