Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add signal on kind dual-stack #15893

Merged
merged 1 commit into from Jan 14, 2020
Merged

Conversation

aojea
Copy link
Member

@aojea aojea commented Jan 14, 2020

The name of the job dual-stack-ipv4-ipv6 reflects the order of the service-cidr ip families.

It seems it will be possible to have IPv4 default or IPv6 default dual-stack cases.

The job can only be triggered manually

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 14, 2020
@aojea
Copy link
Member Author

aojea commented Jan 14, 2020

/assign @BenTheElder

@k8s-ci-robot k8s-ci-robot added area/config Issues or PRs related to code in /config sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Jan 14, 2020
@aojea
Copy link
Member Author

aojea commented Jan 14, 2020

@aojea
Copy link
Member Author

aojea commented Jan 14, 2020

/hold
until this kubernetes-sigs/kind#1255
reports ok

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 14, 2020
@aojea aojea force-pushed the kind-dual branch 2 times, most recently from d3a77ae to d852f5e Compare January 14, 2020 09:53
@aojea
Copy link
Member Author

aojea commented Jan 14, 2020

@aojea
Copy link
Member Author

aojea commented Jan 14, 2020

/hold cancel

The tests are passing
https://prow.k8s.io/view/gcs/kubernetes-jenkins/pr-logs/pull/sigs.k8s.io_kind/1255/pull-kind-conformance-parallel-ipv6/1217134154362130433/
Just they need some tweaks that I'm addressing in this PR
kubernetes/kubernetes#87201

The test can only be trigger manually at this moment

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 14, 2020
@BenTheElder
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 14, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aojea, BenTheElder

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 14, 2020
@k8s-ci-robot k8s-ci-robot merged commit 340096c into kubernetes:master Jan 14, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.18 milestone Jan 14, 2020
@k8s-ci-robot
Copy link
Contributor

@aojea: Updated the job-config configmap in namespace default at cluster default using the following files:

  • key kind-presubmits.yaml using file config/jobs/kubernetes-sigs/kind/kind-presubmits.yaml

In response to this:

The name of the job dual-stack-ipv4-ipv6 reflects the order of the service-cidr ip families.

It seems it will be possible to have IPv4 default or IPv6 default dual-stack cases.

The job can only be triggered manually

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants