Move all prow job definitions into config.yaml. #1903
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
|
github's diff is distorting... |
|
(Please review despite need for rebase causing the test to fail) |
|
LGTM for that commit |
I also plan to move plugins in here after this goes in. This will have a few benefits in the long run: * Adding new job types won't require so much duplication. * The config is passed to plugins. Currently there is no way for plugins to configure themselves at runtime. Passing them this config makes it possible without adding yet more configmaps. * Separating Config and ConfigAgent makes sense. I was using a JobAgent in several places that only needed to load the job configs once. With this change, ConfigAgent mostly just knows how to return a read-only Config struct.
|
Rebased, PTAL. |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
gmarek
pushed a commit
to gmarek/test-infra
that referenced
this pull request
Feb 21, 2017
Automatic merge from submit-queue Fix size check fixes kubernetes#1892 The github api lies about the size of diffs if they are large. If we then subtract out the size of generated files that it is not lieing about we end up with negative numbers. So huge PRs can get XS size. Instead of believing the API and deleting those things we don't care about just sum the things we do care about and use that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First two commits are from #1895, please only review the third here. See the commit message for more details. This will need some rebase, and I'll be sure to pull the changes from the other yaml files into here before merging.