Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prepare Cluster API periodics and presubmit for v1alpha4 #19424

Merged
merged 1 commit into from Oct 5, 2020
Merged

Prepare Cluster API periodics and presubmit for v1alpha4 #19424

merged 1 commit into from Oct 5, 2020

Conversation

vincepri
Copy link
Member

@vincepri vincepri commented Oct 1, 2020

This PR splits all periodics and presubmit between release / main branches, and changes the images to the proper version we'll use next.

/assign @ncdc @detiber

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. area/config Issues or PRs related to code in /config area/jobs sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Oct 1, 2020
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 1, 2020
@vincepri vincepri mentioned this pull request Oct 1, 2020
Merged
@vincepri
Copy link
Member Author

vincepri commented Oct 1, 2020

/test pull-test-infra-bazel

cpanato
cpanato approved these changes Oct 1, 2020
View reviewed changes
Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for adding this @vincepri i did not have time :/

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 1, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato, vincepri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cpanato
Copy link
Member

cpanato commented Oct 1, 2020

/hold for the assigned persons to review

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 1, 2020
@cpanato
Copy link
Member

cpanato commented Oct 1, 2020

/test pull-test-infra-bazel

@vincepri
Copy link
Member Author

vincepri commented Oct 1, 2020

Not sure why the test above is failing, seems maybe unrelated 🤔 ?

@cpanato
Copy link
Member

cpanato commented Oct 1, 2020

yep, looks like, because afaik this job runs the go tests, but I can be completely wrong on that

ncdc
ncdc reviewed Oct 1, 2020
View reviewed changes
config/jobs/kubernetes-sigs/cluster-api/cluster-api-periodics-main.yaml Outdated Show resolved Hide resolved
config/jobs/kubernetes-sigs/cluster-api/cluster-api-presubmits-main.yaml Outdated
@@ -0,0 +1,160 @@
presubmits:
kubernetes-sigs/cluster-api:
- name: pull-cluster-api-build
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you want all these to have the -main suffix?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe? No strong opinions here, up to you :)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think all the other jobs either have -main or -release-0-3 on them?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

config/jobs/kubernetes-sigs/cluster-api/cluster-api-presubmits-release-0-3.yaml
@@ -59,15 +61,16 @@ presubmits:
image: gcr.io/k8s-testimages/kubekins-e2e:v20200929-82b41a1-1.18
annotations:
testgrid-dashboards: sig-cluster-lifecycle-cluster-api
testgrid-tab-name: pr-apidiff
- name: pull-cluster-api-verify
testgrid-tab-name: capi-pr-apidiff-release-0-3
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see you're renaming the PR tabs to be prefixed with capi-. Any particular reason/need for this change?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly for consistency, and if we ever also add the providers here, it'll be already separated

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 2, 2020
@vincepri
Prepare Cluster API periodics and presubmit for v1alpha4
df79d57 
Signed-off-by: Vince Prignano <vincepri@vmware.com>
@ncdc
Copy link
Member

ncdc commented Oct 2, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 2, 2020
fabriziopandini
fabriziopandini reviewed Oct 2, 2020
View reviewed changes
config/jobs/kubernetes-sigs/cluster-api/cluster-api-periodics-release-0-3.yaml
@@ -0,0 +1,83 @@
periodics:
- name: periodic-cluster-api-test-release-0-3
interval: 1h
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can increase the frequency for v0.3 jobs (applies to all)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's do it in another PR?

@vincepri
Copy link
Member Author

vincepri commented Oct 5, 2020

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 5, 2020
@k8s-ci-robot k8s-ci-robot merged commit bb758a0 into kubernetes:master Oct 5, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.20 milestone Oct 5, 2020
@k8s-ci-robot
Copy link
Contributor

@vincepri: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key cluster-api-ci.yaml using file ``
  • key cluster-api-periodics-main.yaml using file config/jobs/kubernetes-sigs/cluster-api/cluster-api-periodics-main.yaml
  • key cluster-api-periodics-release-0-3.yaml using file config/jobs/kubernetes-sigs/cluster-api/cluster-api-periodics-release-0-3.yaml
  • key cluster-api-presubmits.yaml using file ``
  • key cluster-api-presubmits-main.yaml using file config/jobs/kubernetes-sigs/cluster-api/cluster-api-presubmits-main.yaml
  • key cluster-api-presubmits-release-0-3.yaml using file config/jobs/kubernetes-sigs/cluster-api/cluster-api-presubmits-release-0-3.yaml

In response to this:

This PR splits all periodics and presubmit between release / main branches, and changes the images to the proper version we'll use next.

/assign @ncdc @detiber

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ncdc ncdc ncdc left review comments

@fabriziopandini fabriziopandini fabriziopandini left review comments

@cpanato cpanato cpanato approved these changes

@justinsb justinsb Awaiting requested review from justinsb

@timothysc timothysc Awaiting requested review from timothysc

Assignees

@ncdc ncdc

@detiber detiber

@cpanato cpanato

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.20
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@vincepri @k8s-ci-robot @cpanato @ncdc @fabriziopandini @detiber