Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate Network Policy testjob to podutils #20336

Merged
merged 1 commit into from
Jan 20, 2021
Merged

Migrate Network Policy testjob to podutils #20336

merged 1 commit into from
Jan 20, 2021

Conversation

rikatz
Copy link
Contributor

@rikatz rikatz commented Dec 23, 2020 •
edited

Signed-off-by: Ricardo Pchevuzinske Katz ricardo.katz@gmail.com

Started migrating sig-net jobs to podutils, for now let's see if the network policy job works fine :)

Part of: #20324

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 23, 2020
@rikatz
Copy link
Contributor Author

rikatz commented Dec 23, 2020

/assign @aojea @jayunit100

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. area/config Issues or PRs related to code in /config area/jobs sig/network Categorizes an issue or PR as relevant to SIG Network. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Dec 23, 2020
@rikatz
Copy link
Contributor Author

rikatz commented Dec 23, 2020

/uncc @bowei @MrHohn
/cc @aojea

@k8s-ci-robot k8s-ci-robot requested review from aojea and removed request for bowei and MrHohn December 23, 2020 12:55
@jayunit100
Copy link
Member

Looks ok to me ! Should we merge and iterate on this ? I don’t see any logic changes so as long as it’s plugged in to the new stuff properly we’re good !!!!!

@rikatz
Copy link
Contributor Author

rikatz commented Dec 23, 2020

The biggest change here is that we don't rely on bootstrap.py anymore to create the resources, pull artifacts, etc etc.

It's not a huge change, but sig-testing has deprecated bootstrap.py and asked to migrate some jobs, so I guess this is a good start :)

aojea
aojea reviewed Dec 23, 2020
View reviewed changes
config/jobs/kubernetes/sig-network/sig-network-misc.yaml Outdated
Comment on lines 11 to 15
extra_refs:
- org: kubernetes
repo: test-infra
base_ref: master
path_alias: k8s.io/test-infra
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do you need to pull k8s.io/test-infra?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because of /workspace/scenarios/kubernetes_e2e.py which is in test-infra repo :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wait, I'm trying to remember why actually we used this, and maybe wasn't because of the scenarios, but because of 67e14ce#diff-9495ba672589316a9265fd090ecb9c3c74fd414a11386acafda27df4bd409409

As we do not use anything at test-infra I'll remove it

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, I'm wondering if --stage=gs://kubernetes-release-pull/ci/pull-kubernetes-e2e-ubuntu-gce-network-policies is necessary or if this is also covered by podutils, BUT I think for now will leave this way

@rikatz
Copy link
Contributor Author

rikatz commented Dec 23, 2020

Removed the extra-args, left the stage=gs:// because I guess podutils only deals with the artifacts pushing, not the staging :)

@aojea
Copy link
Member

aojea commented Dec 23, 2020

let´s tackle this next week, the jobs look stable but we should let them soak

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 30, 2020
@rikatz
Copy link
Contributor Author

rikatz commented Jan 3, 2021

@aojea let me know when I can rebase this so we can test if with podutils is better :)

Seems that it's already done with #20308 so just need now to see if the behavior keeps the same :)

@rikatz
Migrate Network Pòlicy testjob to podutils
270eaf8 
Signed-off-by: Ricardo Pchevuzinske Katz <ricardo.katz@gmail.com>
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 13, 2021
@spiffxp
Copy link
Member

spiffxp commented Jan 19, 2021

/test pull-test-infra-integration
#20498 (comment)

@aojea
Copy link
Member

aojea commented Jan 20, 2021

/lgtm
🤞
Thanks Ricardo

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 20, 2021
@aojea
Copy link
Member

aojea commented Jan 20, 2021

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aojea, rikatz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 20, 2021
@k8s-ci-robot k8s-ci-robot merged commit 1abfa00 into kubernetes:master Jan 20, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.21 milestone Jan 20, 2021
@k8s-ci-robot
Copy link
Contributor

@rikatz: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key sig-network-misc.yaml using file config/jobs/kubernetes/sig-network/sig-network-misc.yaml

In response to this:

Signed-off-by: Ricardo Pchevuzinske Katz ricardo.katz@gmail.com

Started migrating sig-net jobs to podutils, for now let's see if the network policy job works fine :)

Part of: #20324

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aojea aojea aojea left review comments

Assignees

@jayunit100 jayunit100

@aojea aojea

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/network Categorizes an issue or PR as relevant to SIG Network. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.21
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@rikatz @jayunit100 @aojea @spiffxp @k8s-ci-robot