Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

user apiserver /healthz instead of cs check #20909

Closed
wants to merge 1 commit into from

Conversation

pacoxu
Copy link
Member

@pacoxu pacoxu commented Feb 19, 2021

As componentstatus as deprecated in 1.19+, kubernetes/kubernetes#93570 conformance test should not use it at all.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 19, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: pacoxu
To complete the pull request process, please assign feiskyer after the PR has been reviewed.
You can assign the PR to them by writing /assign @feiskyer in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added area/kubetest size/S Denotes a PR that changes 10-29 lines, ignoring generated files. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Feb 19, 2021
@pacoxu pacoxu force-pushed the componentstatus/depre-1 branch 2 times, most recently from fb1dbf5 to 9a52972 Compare February 19, 2021 07:41
Signed-off-by: pacoxu <paco.xu@daocloud.io>
@amwat
Copy link
Contributor

amwat commented Feb 26, 2021

Thanks for the change!

I think this code path is no longer used anywhere in CI (not sure if folks are using it locally) since it's under
--deployment=conformance

https://cs.k8s.io/?q=--deployment%3Dconformance&i=nope&files=&excludeFiles=&repos=

Note that kubetest is deprecated in general, so we are only accepting critical bug fixes which affect existing CI jobs
https://github.com/kubernetes/test-infra/tree/master/kubetest#deprecation-notice

Not to mention we currently still officially support testing for 1.18

@pacoxu
Copy link
Member Author

pacoxu commented Feb 26, 2021

@amwat thanks for the information. I see the message in conformance testing log, if that is deprecated, no need to change this.

Let me close it.
/close

@k8s-ci-robot
Copy link
Contributor

@pacoxu: Closed this PR.

In response to this:

@amwat thanks for the information. I see the message in conformance testing log, if that is deprecated, no need to change this.

Let me close it.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/kubetest cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants