Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swap gce-conformance on sig-release-master-blocking from kubetest to kubetest2 #21180

Merged
merged 1 commit into from
Mar 8, 2021

Conversation

amwat
Copy link
Contributor

@amwat amwat commented Mar 5, 2021

First of many! No bootstrap, no scenarios, no kubetest :)

xref: kubernetes/enhancements#2464

The kubetest2 gce-conformance job has been stable for a while:
https://testgrid.k8s.io/conformance-all#Conformance%20-%20GCE%20-%20master%20-%20kubetest2

the old job will still be visible at: https://testgrid.k8s.io/conformance-all#Conformance%20-%20GCE%20-%20master
will not be turned down yet

Only targetting master, older release branches will still use kubetest based jobs.

/cc @BenTheElder @spiffxp
/cc @kubernetes/ci-signal
/cc @kubernetes/sig-release

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. area/config Issues or PRs related to code in /config area/jobs area/provider/gcp Issues or PRs related to gcp provider sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Mar 5, 2021
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 5, 2021
Copy link
Member

@spiffxp spiffxp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/area conformance
/cc @dims @johnbelamaric
as FYI

I compared results of latest runs

The difference in number of tests passed is due to the e2e.go suite having 13 steps, where kubetest2's (unamed) suite has 4 steps

Comparing durations on testgrid:

Overall is about 10min longer for kubetest2, but Test is about 10min shortee for kubetest2. Turns out this is due to the fact that there is a kubetest2.Build stage.

The kubetest2 job hasn't been passing for a full two weeks, but I see nothing in its history to indicate that it's providing lower quality signal than the job it's replacing.

So, suggestions for followup:

  • kubetest2 job should download pre-built binaries from k8s-release-dev bucket
  • kubetest2 should give its "meta" suite a name, maybe kubetest2

/approve
/lgtm
/hold
for comment, I'm gonna go ping release team

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. area/conformance Issues or PRs related to kubernetes conformance tests labels Mar 8, 2021
@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Mar 8, 2021
@spiffxp
Copy link
Member

spiffxp commented Mar 8, 2021

/assign @thejoycekung @palnabarun
Release team: CI Signal lead, Release lead
/assign @hasheddan @jeremyrickard
SIG Release TLs

I'll remove /hold If no objections by SIG Testing meeting tomorrow at 10am PT, or +1's from at least one of each /assign line

Copy link
Contributor

@hasheddan hasheddan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Thanks @amwat!

@amwat
Copy link
Contributor Author

amwat commented Mar 8, 2021

+1 ack on the differences

@BenTheElder
Copy link
Member

Adding support for GCE extract (kubernetes-sigs/kubetest2#106) (although master job should ideally be building from master? 🤔 )

No, the vast majority of jobs targeting any branch use the existing uploads of this. It adds a little latency (the time it takes us to make quick-release + upload) but saves us a lot of compute, we have a continuous build to consume.

(I need to fix this for KIND, but it was not subsuming an existing job, and for some time we were intentionally using different builds in some jobs).

@chizhg
Copy link
Contributor

chizhg commented Mar 8, 2021

  • testsuite name was added in kubernetes-sigs/kubetest2#93 and it shows up as such in testgrid, need to figure out why it's not showing up in the junit lens

Do you have a spyglass link for this? I checked one of our test runs and the kubetest2 testsuites looks good in the junit lens.

Copy link
Contributor

@thejoycekung thejoycekung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

The job looks stable, and I think it's super awesome we're moving away from bootstrap. Thanks y'all!

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: amwat, hasheddan, spiffxp, thejoycekung

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@amwat
Copy link
Contributor Author

amwat commented Mar 8, 2021

Do you have a spyglass link for this? I checked one of our test runs and the kubetest2 testsuites looks good in the junit lens.

tracked in kubernetes-sigs/kubetest2#107

@spiffxp
Copy link
Member

spiffxp commented Mar 8, 2021

/hold cancel
Thanks for the review all!

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 8, 2021
@k8s-ci-robot k8s-ci-robot merged commit 7c44414 into kubernetes:master Mar 8, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.21 milestone Mar 8, 2021
@k8s-ci-robot
Copy link
Contributor

@amwat: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key gce-conformance.yaml using file config/jobs/kubernetes/sig-cloud-provider/gcp/gce-conformance.yaml

In response to this:

First of many! No bootstrap, no scenarios, no kubetest :)

xref: kubernetes/enhancements#2464

The kubetest2 gce-conformance job has been stable for a while:
https://testgrid.k8s.io/conformance-all#Conformance%20-%20GCE%20-%20master%20-%20kubetest2

the old job will still be visible at: https://testgrid.k8s.io/conformance-all#Conformance%20-%20GCE%20-%20master
will not be turned down yet

Only targetting master, older release branches will still use kubetest based jobs.

/cc @BenTheElder @spiffxp
/cc @kubernetes/ci-signal
/cc @kubernetes/sig-release

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@amwat amwat deleted the migrateconformance branch March 9, 2021 00:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/conformance Issues or PRs related to kubernetes conformance tests area/jobs area/provider/gcp Issues or PRs related to gcp provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants