Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

jobs: prep slack-infra for default branch rename #21607

Merged
merged 2 commits into from
Apr 1, 2021
Merged

jobs: prep slack-infra for default branch rename #21607

merged 2 commits into from
Apr 1, 2021

Conversation

spiffxp
Copy link
Member

@spiffxp spiffxp commented Apr 1, 2021 •
edited

ref: kubernetes-sigs/slack-infra#50

also updating owners to match with kubernetes-sigs/slack-infra#51

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Apr 1, 2021
@k8s-ci-robot
Copy link
Contributor

@hanyouqing: changing LGTM is restricted to collaborators

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@spiffxp spiffxp mentioned this pull request Apr 1, 2021
Closed
16 tasks
@spiffxp
Copy link
Member Author

spiffxp commented Apr 1, 2021

/sig contributor-experience

@k8s-ci-robot k8s-ci-robot added the sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience. label Apr 1, 2021
@spiffxp
Copy link
Member Author

spiffxp commented Apr 1, 2021

side-note... I'm not sure why this didn't get auto-labeled area/jobs? config/jobs/OWNERS should have done that for me

@spiffxp
Copy link
Member Author

spiffxp commented Apr 1, 2021 •
edited

/retitle jobs: prep slack-infra for default branch rename

(thought this might a bug due to owners-label plugin being specified for kubernetes and somehow the extract kubernetes/test-infra plugins overrode... so I tried something else specified for the org)

@k8s-ci-robot k8s-ci-robot changed the title jobs: prep slack-infra for branch rename jobs: prep slack-infra for default branch rename Apr 1, 2021
@spiffxp
owners: update config/jobs/kubernetes-sigs/slack-infra
21db7de 
sync with owners in kubernetes-sigs/slack-infra
@k8s-ci-robot k8s-ci-robot added area/config Issues or PRs related to code in /config area/jobs sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Apr 1, 2021
@spiffxp
Copy link
Member Author

spiffxp commented Apr 1, 2021

/cc @jeefy @nikhita @cpanato

cpanato
cpanato approved these changes Apr 1, 2021
View reviewed changes
Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 1, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato, hanyouqing, spiffxp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit ce7523c into kubernetes:master Apr 1, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.21 milestone Apr 1, 2021
@k8s-ci-robot
Copy link
Contributor

@spiffxp: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key k8s-staging-slack-infra.yaml using file config/jobs/image-pushing/k8s-staging-slack-infra.yaml

In response to this:

ref: kubernetes-sigs/slack-infra#50

also updating owners to match with kubernetes-sigs/slack-infra#51

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@spiffxp spiffxp deleted the pre-branch-rename-slack-infra branch April 1, 2021 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hanyouqing hanyouqing hanyouqing approved these changes

@cpanato cpanato cpanato approved these changes

@dims dims Awaiting requested review from dims

@michelle192837 michelle192837 Awaiting requested review from michelle192837

@jeefy jeefy Awaiting requested review from jeefy

@nikhita nikhita Awaiting requested review from nikhita

Assignees

@cpanato cpanato

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.21
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@spiffxp @k8s-ci-robot @hanyouqing @cpanato