Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update milestone applier for k/website dev-1.22 release branch #21727

Merged
merged 1 commit into from
Apr 13, 2021
Merged

Update milestone applier for k/website dev-1.22 release branch #21727

merged 1 commit into from
Apr 13, 2021

Conversation

reylejano
Copy link
Member

Update the k/website milestone applier for the dev-1.22 branch to automatically apply the 1.22 milestone for PRs created against the dev-1.22 branch

/hold for review from @kubernetes/sig-docs-leads

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. area/config Issues or PRs related to code in /config sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Apr 8, 2021
@reylejano
Copy link
Member Author

/cc @PI-Victor

@dims
Copy link
Member

dims commented Apr 8, 2021

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, reylejano

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 8, 2021
@chases2 chases2 removed their request for review April 9, 2021 16:15
@PI-Victor
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 12, 2021
irvifa
irvifa reviewed Apr 13, 2021
View reviewed changes
Copy link
Member

@irvifa irvifa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
Please feel free to hold cancel it @reylejano

@sftim
Copy link
Contributor

sftim commented Apr 13, 2021

Please feel free to hold cancel it @reylejano

Or indeed @PI-Victor !

@PI-Victor
Copy link
Member

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 13, 2021
@k8s-ci-robot k8s-ci-robot merged commit 9a25e9f into kubernetes:master Apr 13, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.22 milestone Apr 13, 2021
@k8s-ci-robot
Copy link
Contributor

@reylejano: Updated the plugins configmap in namespace default at cluster test-infra-trusted using the following files:

  • key plugins.yaml using file config/prow/plugins.yaml

In response to this:

Update the k/website milestone applier for the dev-1.22 branch to automatically apply the 1.22 milestone for PRs created against the dev-1.22 branch

/hold for review from @kubernetes/sig-docs-leads

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@reylejano reylejano deleted the update-prow-for-website-1.22-milestone branch October 8, 2021 20:43
@Rishit-dagli Rishit-dagli mentioned this pull request Aug 16, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@irvifa irvifa irvifa left review comments

@cblecker cblecker Awaiting requested review from cblecker

@dims dims Awaiting requested review from dims

@PI-Victor PI-Victor Awaiting requested review from PI-Victor

Assignees

@PI-Victor PI-Victor

@irvifa irvifa

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.22
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@reylejano @dims @k8s-ci-robot @PI-Victor @sftim @irvifa