Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

jobs: fix k8s.io deploy jobs #21954

Merged
merged 5 commits into from Apr 27, 2021
Merged

jobs: fix k8s.io deploy jobs #21954

merged 5 commits into from Apr 27, 2021

Conversation

spiffxp
Copy link
Member

@spiffxp spiffxp commented Apr 26, 2021

Main motivation was to fix the fact that the post-k8sio-groups job didn't trigger when a change to groups/committee-product-security/groups.yaml was merged (ref: kubernetes/k8s.io#1973 (comment))

However I took care of a few other things while I was here:

  • prep prow deploy jobs to use in-repo deploy scripts
  • run the ci-k8sio-groups job 4x as frequently since postsubmits seem unreliable
  • drop the perma-failing ci-k8sio-groups-head experiment job
  • drop the "groups" container name copy-pasta from jobs

@spiffxp
jobs: remove ci-k8sio-groups-head
967da09 
was an experiment to see if pod-utils supported cloning HEAD, they do
not
@spiffxp
jobs: run ci-k8sio-groups every 6h
31dbde4
@spiffxp
jobs: drop container name from k8s.io jobs
73d59af
@spiffxp
jobs: adjust k8s.io run_if_changed regexes
bedcde0 
specifically

- trim post-k8sio-groups to pick up all changes under groups (code
  changes or configs other than groups.yaml)
- trim post-k8sio-deploy-prow* to pick up all changes for prow clusters,
  not just changes to their resources
@spiffxp
jobs: k8s.io prow deploy jobs use in-repo script
8ca738a 
fall back to old behavior if the script isn't present
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 26, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: spiffxp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 26, 2021
@spiffxp spiffxp mentioned this pull request Apr 26, 2021
Merged
@spiffxp
Copy link
Member Author

spiffxp commented Apr 26, 2021

/cc @ameukam

@ameukam
Copy link
Member

ameukam commented Apr 27, 2021

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 27, 2021
@k8s-ci-robot k8s-ci-robot merged commit 9698688 into kubernetes:master Apr 27, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.22 milestone Apr 27, 2021
@k8s-ci-robot
Copy link
Contributor

@spiffxp: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key wg-k8s-infra-trusted.yaml using file config/jobs/kubernetes/wg-k8s-infra/trusted/wg-k8s-infra-trusted.yaml

In response to this:

Main motivation was to fix the fact that the post-k8sio-groups job didn't trigger when a change to groups/committee-product-security/groups.yaml was merged (ref: kubernetes/k8s.io#1973 (comment))

However I took care of a few other things while I was here:

  • prep prow deploy jobs to use in-repo deploy scripts
  • run the ci-k8sio-groups job 4x as frequently since postsubmits seem unreliable
  • drop the perma-failing ci-k8sio-groups-head experiment job
  • drop the "groups" container name copy-pasta from jobs

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@spiffxp spiffxp deleted the fix-k8sio-deploy-jobs branch July 12, 2021 22:08
@spiffxp
Copy link
Member Author

spiffxp commented Aug 27, 2021

ref: kubernetes/k8s.io#460 for triggering the groups jobs on more than groups.yaml

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BenTheElder BenTheElder Awaiting requested review from BenTheElder

@thockin thockin Awaiting requested review from thockin

@ameukam ameukam Awaiting requested review from ameukam

Assignees

@ameukam ameukam

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.22
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@spiffxp @k8s-ci-robot @ameukam