Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CAPN Presubmit - removing old branch references #22309

Merged
merged 1 commit into from
May 21, 2021
Merged

CAPN Presubmit - removing old branch references #22309

merged 1 commit into from
May 21, 2021

Conversation

christopherhein
Copy link
Member

@christopherhein christopherhein commented May 21, 2021 •
edited

This cleans up the last references to master branch, although still is using image names with master in the tag, this will require more investigation.

Related

Closes kubernetes-sigs/cluster-api-provider-nested#67

Signed-off-by: Chris Hein me@chrishein.com

@christopherhein
CAPN Presubmit - removing old branch references
5a2eac9 
Signed-off-by: Chris Hein <me@chrishein.com>
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. area/config Issues or PRs related to code in /config area/jobs sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels May 21, 2021
@christopherhein
Copy link
Member Author

/kind cleanup

@k8s-ci-robot k8s-ci-robot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label May 21, 2021
@christopherhein christopherhein mentioned this pull request May 21, 2021
Closed
13 tasks
@christopherhein
Copy link
Member Author

/unassign @timothysc
/assign @vincepri

@k8s-ci-robot k8s-ci-robot assigned vincepri and unassigned timothysc May 21, 2021
vincepri
vincepri approved these changes May 21, 2021
View reviewed changes
Copy link
Member

@vincepri vincepri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 21, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: christopherhein, vincepri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 5fa82d8 into kubernetes:master May 21, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.22 milestone May 21, 2021
@k8s-ci-robot
Copy link
Contributor

@christopherhein: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key cluster-api-provider-nested-presubmits.yaml using file config/jobs/kubernetes-sigs/cluster-api-provider-nested/cluster-api-provider-nested-presubmits.yaml

In response to this:

This cleans up the last references to master branch, although still is using image names with master in the tag, this will require more investigation.

Related

Closes kubernetes-sigs/cluster-api-provider-nested#67

Signed-off-by: Chris Hein me@chrishein.com

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@christopherhein christopherhein deleted the capn/cleanup-prow branch May 21, 2021 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vincepri vincepri vincepri approved these changes

@justinsb justinsb Awaiting requested review from justinsb

@timothysc timothysc Awaiting requested review from timothysc

Assignees

@vincepri vincepri

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.22
Development

Successfully merging this pull request may close these issues.

✨ Clean up Prow referenced for old branch name
4 participants
@christopherhein @k8s-ci-robot @vincepri @timothysc