Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable docker-in-docker for cloud-provider-gcp tasks. #23098

Merged
merged 1 commit into from Aug 4, 2021
Merged

enable docker-in-docker for cloud-provider-gcp tasks. #23098

merged 1 commit into from Aug 4, 2021

Conversation

jiahuif
Copy link
Member

@jiahuif jiahuif commented Aug 2, 2021

k/cloud-provider-gcp is switching to docker from Bazel to build container images, as a step of producing the final tarballs.

This PR enables docker-in-docker (dind for short) for all tasks that invokes building, so that docker can be used for building container image.

Note: this change will NOT break current configuration.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 2, 2021
@k8s-ci-robot k8s-ci-robot added area/config Issues or PRs related to code in /config area/jobs area/provider/aws Issues or PRs related to aws provider sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Aug 2, 2021
@jiahuif
Copy link
Member Author

jiahuif commented Aug 4, 2021

/remove-area provider/aws
/area provider/gcp

@k8s-ci-robot
Copy link
Contributor

@jiahuif: Those labels are not set on the issue: area/provider/was

In response to this:

/remove-area provider/was
/area provider/gcp

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the area/provider/gcp Issues or PRs related to gcp provider label Aug 4, 2021
@jiahuif
Copy link
Member Author

jiahuif commented Aug 4, 2021

/remove-area provider/aws

@k8s-ci-robot k8s-ci-robot removed the area/provider/aws Issues or PRs related to aws provider label Aug 4, 2021
@jiahuif
Copy link
Member Author

jiahuif commented Aug 4, 2021

/assign @amwat
Would you mind taking a look at this?

so that docker can be used for building container image.
@k8s-ci-robot k8s-ci-robot added the area/provider/aws Issues or PRs related to aws provider label Aug 4, 2021
Copy link
Contributor

@amwat amwat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 4, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: amwat, jiahuif

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 4, 2021
@k8s-ci-robot k8s-ci-robot merged commit a85caf3 into kubernetes:master Aug 4, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.22 milestone Aug 4, 2021
@k8s-ci-robot
Copy link
Contributor

@jiahuif: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key cloud-provider-gcp-periodics.yaml using file config/jobs/kubernetes/cloud-provider-gcp/cloud-provider-gcp-periodics.yaml
  • key cloud-provider-gcp-presubmits.yaml using file config/jobs/kubernetes/cloud-provider-gcp/cloud-provider-gcp-presubmits.yaml

In response to this:

k/cloud-provider-gcp is switching to docker from Bazel to build container images, as a step of producing the final tarballs.

This PR enables docker-in-docker (dind for short) for all tasks that invokes building, so that docker can be used for building container image.

Note: this change will NOT break current configuration.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs area/provider/aws Issues or PRs related to aws provider area/provider/gcp Issues or PRs related to gcp provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants