Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

releng: Update references to CIP repo to sigs.k8s.io/promo-tools #23605

Merged
merged 3 commits into from Sep 15, 2021

Conversation

justaugustus
Copy link
Member

(We'll defer alpha-sorts and file renames to a follow-up to avoid a painful review/becoming a rebase magnet.)

/hold for consensus timeout: https://groups.google.com/g/kubernetes-dev/c/YnIYtEBURvk
ref: kubernetes-sigs/promo-tools#424

Signed-off-by: Stephen Augustus foo@auggie.dev

cc: @kubernetes/release-engineering

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 15, 2021
@k8s-ci-robot k8s-ci-robot added area/artifacts Issues or PRs related to the hosting of release artifacts for subprojects area/config Issues or PRs related to code in /config area/jobs area/label_sync Issues or PRs related to code in /label_sync area/prow Issues or PRs related to prow area/release-eng Issues or PRs related to the Release Engineering subproject sig/release Categorizes an issue or PR as relevant to SIG Release. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Sep 15, 2021
@justaugustus
Copy link
Member Author

/assign @spiffxp @mrbobbytables @cblecker
As @kubernetes/owners (though I've found there are no disruptive tasks around branch renames)

(Will fix the labels.md in the next push.)

@justaugustus justaugustus changed the title [WIP] releng: Update references to CIP repo to sigs.k8s.io/promo-tools releng: Update references to CIP repo to sigs.k8s.io/promo-tools Sep 15, 2021
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 15, 2021
@justaugustus
Copy link
Member Author

/assign @puerco @cpanato @Verolop @ameukam
cc: @kubernetes/release-engineering @kubernetes/wg-k8s-infra

@ameukam
Copy link
Member

ameukam commented Sep 15, 2021

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 15, 2021
Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

thanks! <3

Signed-off-by: Stephen Augustus <foo@auggie.dev>
Signed-off-by: Stephen Augustus <foo@auggie.dev>
Signed-off-by: Stephen Augustus <foo@auggie.dev>
Copy link
Member

@spiffxp spiffxp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 15, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato, justaugustus, spiffxp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 15, 2021
@cpanato
Copy link
Member

cpanato commented Sep 15, 2021

/lgtm

@justaugustus
Copy link
Member Author

/hold cancel
Both this and kubernetes-sigs/promo-tools#428 have been approved.

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 15, 2021
@k8s-ci-robot k8s-ci-robot merged commit 8010010 into kubernetes:master Sep 15, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.23 milestone Sep 15, 2021
@k8s-ci-robot
Copy link
Contributor

@justaugustus: Updated the following 3 configmaps:

  • label-config configmap in namespace test-pods at cluster test-infra-trusted using the following files:
    • key labels.yaml using file label_sync/labels.yaml
  • job-config configmap in namespace default at cluster test-infra-trusted using the following files:
    • key k8s-staging-artifact-promoter.yaml using file config/jobs/image-pushing/releng/k8s-staging-artifact-promoter.yaml
    • key container-image-promoter.yaml using file ``
    • key promo-tools.yaml using file config/jobs/kubernetes/sig-release/promo-tools/promo-tools.yaml
  • plugins configmap in namespace default at cluster test-infra-trusted using the following files:
    • key plugins.yaml using file config/prow/plugins.yaml

In response to this:

(We'll defer alpha-sorts and file renames to a follow-up to avoid a painful review/becoming a rebase magnet.)

/hold for consensus timeout: https://groups.google.com/g/kubernetes-dev/c/YnIYtEBURvk
ref: kubernetes-sigs/promo-tools#424

Signed-off-by: Stephen Augustus foo@auggie.dev

cc: @kubernetes/release-engineering

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/artifacts Issues or PRs related to the hosting of release artifacts for subprojects area/config Issues or PRs related to code in /config area/jobs area/label_sync Issues or PRs related to code in /label_sync area/prow Issues or PRs related to prow area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/release Categorizes an issue or PR as relevant to SIG Release. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants