Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

images: trigger image builds for bigquery, gcloud-in-go, krte, kubemci #23849

Merged
merged 5 commits into from
Sep 30, 2021
Merged

images: trigger image builds for bigquery, gcloud-in-go, krte, kubemci #23849

merged 5 commits into from
Sep 30, 2021

Conversation

spiffxp
Copy link
Member

@spiffxp spiffxp commented Sep 30, 2021

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 30, 2021
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. area/images sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Sep 30, 2021
@spiffxp spiffxp mentioned this pull request Sep 30, 2021
Open
17 tasks
@spiffxp
Copy link
Member Author

spiffxp commented Sep 30, 2021

/cc @cjwagner @BenTheElder

@spiffxp
Copy link
Member Author

spiffxp commented Sep 30, 2021

/retest
flake

--- FAIL: TestDiskCachePruning (0.06s)
    ghproxy_test.go:57: got a reequest for path /app
    ghproxy_test.go:57: got a reequest for path /app/installations
    ghproxy_test.go:57: got a reequest for path /app/installations/0/access_tokens
    ghproxy_test.go:57: got a reequest for path /repos/org/repo/git/refs/dev
    ghproxy_test.go:97: expected two cache paritions, one for the app and one for the app installation, got 3
    ghproxy_test.go:107: expected one cache partition for the app as the one for the installation should be cleaned up, got  2
FAIL

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 30, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fejta, spiffxp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit b6c4097 into kubernetes:master Sep 30, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.23 milestone Sep 30, 2021
@spiffxp spiffxp deleted the trigger-image-builds branch October 1, 2021 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fejta fejta fejta approved these changes

@amwat amwat Awaiting requested review from amwat

@BenTheElder BenTheElder Awaiting requested review from BenTheElder

@cjwagner cjwagner Awaiting requested review from cjwagner

Assignees

@fejta fejta

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/images cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.23
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@spiffxp @k8s-ci-robot @fejta