Make testfreeze plugin work with auto fast-forward #26190
Conversation
We enabled the automatic fast forward for the v1.25 release branch in: kubernetes#26188 This means we now have to adapt the testfreeze plugin to take this into account. Beside mentioning the auto fast forward the plugin will now determine the last successful run as well. Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
k8s-ci-robot
added
cncf-cla: yes
k8s-ci-robot
added
area/prow/plugins
|
@kubernetes/sig-contributor-experience PTAL, I'll send out a note to k-dev after this one has been merged :) |
|
cc @kubernetes/release-managers |
| InTestFreeze: true, | ||
| Tag: "v1.23.0", | ||
| Branch: "release-1.23", | ||
| LastFastForward: "Wed May 4 16:15:37 CEST 2022", |
There was a problem hiding this comment.
non-blocking and nit: this extra space between May and 4 is intentional or this is an output when using the function?
There was a problem hiding this comment.
It's intentional, depending on which format we want to apply to the date. The GitHub markdown parser would strip the double spaces in any case, like: Wed May 4 16:15:37 CEST 2022
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cpanato, saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
We enabled the automatic fast forward for the v1.25 release branch in: #26188
This means we now have to adapt the testfreeze plugin to take this into account. Beside mentioning the auto fast forward the plugin will now determine the last successful run as well.
Refers to kubernetes/release#2386