Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove CSIMigration=false from generated config #26647

Closed
wants to merge 1 commit into from
Closed

chore: remove CSIMigration=false from generated config #26647

wants to merge 1 commit into from

Conversation

Jiawei0227
Copy link
Contributor

CSIMigration is going to be GA kubernetes/kubernetes#110410
The feature gate will be locked so remove this disable flag from the config file.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 21, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Jiawei0227
To complete the pull request process, please assign palnabarun after the PR has been reviewed.
You can assign the PR to them by writing /assign @palnabarun in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the area/config Issues or PRs related to code in /config label Jun 21, 2022
@k8s-ci-robot k8s-ci-robot added area/jobs area/release-eng Issues or PRs related to the Release Engineering subproject sig/release Categorizes an issue or PR as relevant to SIG Release. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Jun 21, 2022
@Jiawei0227
Copy link
Contributor Author

cc @liggitt @msau42

I could not find where this flag come from so I directly edit the generated file. Let me know if I need to do something different.

@Jiawei0227 Jiawei0227 mentioned this pull request Jun 21, 2022
Merged
liggitt
liggitt reviewed Jun 21, 2022
View reviewed changes
config/jobs/kubernetes/generated/generated.yaml
@@ -724,7 +724,7 @@ periodics:
- --test_args=--ginkgo.focus=\[Feature:(ExternalTrafficLocalOnly)\] --minStartupPods=8
- --env=KUBE_PROXY_DAEMONSET=true
- --env=ENABLE_POD_PRIORITY=true
- --env=KUBE_FEATURE_GATES=AllAlpha=true,CSIMigration=false
- --env=KUBE_FEATURE_GATES=AllAlpha=true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm... is this testing master / 1.25, or 1.21? if 1.21, I guess we still need this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, yeah looking at it again, it seems it is targetting 1.21 here. The upper one is targetting 1.22.

In both cases, we might still need these flags.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we even support 1.21 anymore?

@Jiawei0227 Jiawei0227 closed this Jun 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liggitt liggitt liggitt left review comments

@msau42 msau42 msau42 left review comments

@jeremyrickard jeremyrickard Awaiting requested review from jeremyrickard

@palnabarun palnabarun Awaiting requested review from palnabarun

Assignees
No one assigned
Labels
area/config Issues or PRs related to code in /config area/jobs area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. sig/release Categorizes an issue or PR as relevant to SIG Release. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Jiawei0227 @k8s-ci-robot @liggitt @msau42