Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rework cloud-provider-gcp tests #26662

Merged
merged 1 commit into from
Jun 24, 2022
Merged

Rework cloud-provider-gcp tests #26662

merged 1 commit into from
Jun 24, 2022

Conversation

jprzychodzen
Copy link
Contributor

  • Add periodic test that duplicates presubmit to have a visiblity into flakines
  • Fix flakiness of e2e-full test by increasing node size
  • Bootstrap cloud-provide-gcp presets

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 24, 2022
@k8s-ci-robot k8s-ci-robot added area/config Issues or PRs related to code in /config area/jobs area/provider/gcp Issues or PRs related to gcp provider sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Jun 24, 2022
@jprzychodzen
Rework cloud-provider-gcp tests
2fef4de 
* Add periodic test that duplicates presubmit to have a visiblity into flakines
* Fix flakiness of e2e-full test by increasing node size
* Bootstrap cloud-provide-gcp presets
@jprzychodzen
Copy link
Contributor Author

/assign @mikedanese

@dims
Copy link
Member

dims commented Jun 24, 2022

/approve
/lgtm

/hold please feel free to remove hold when ready

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 24, 2022
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 24, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, jprzychodzen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 24, 2022
@jprzychodzen
Copy link
Contributor Author

Thanks @dims

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 24, 2022
@k8s-ci-robot k8s-ci-robot merged commit aba53c7 into kubernetes:master Jun 24, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.25 milestone Jun 24, 2022
@k8s-ci-robot
Copy link
Contributor

@jprzychodzen: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key cloud-provider-gcp-periodics.yaml using file config/jobs/kubernetes/cloud-provider-gcp/cloud-provider-gcp-periodics.yaml
  • key cloud-provider-gcp-presets.yaml using file config/jobs/kubernetes/cloud-provider-gcp/cloud-provider-gcp-presets.yaml
  • key cloud-provider-gcp-presubmits.yaml using file config/jobs/kubernetes/cloud-provider-gcp/cloud-provider-gcp-presubmits.yaml

In response to this:

  • Add periodic test that duplicates presubmit to have a visiblity into flakines
  • Fix flakiness of e2e-full test by increasing node size
  • Bootstrap cloud-provide-gcp presets

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

This was referenced Jun 24, 2022
Closed
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpbetz jpbetz Awaiting requested review from jpbetz

@mikedanese mikedanese Awaiting requested review from mikedanese

Assignees

@dims dims

@mikedanese mikedanese

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs area/provider/gcp Issues or PRs related to gcp provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.25
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jprzychodzen @dims @k8s-ci-robot @mikedanese